Migrate to neostandard (#951)

Also add lint annotations

.github/workflows/eslint.yml

@@ -0,0 +1,26 @@
+name: ESLint
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
+permissions:
+  contents: read
+
+jobs:
+  eslint:
+    name: ESLint
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - uses: pnpm/action-setup@v4
+    - name: Set up Node
+      uses: actions/setup-node@v4
+      with:
+        node-version: '18'
+    - name: Install node dependencies
+      run: pnpm install
+    - name: Run JavaScript linter
+      run: pnpm eslint

.github/workflows/rubocop.yml

@@ -29,4 +29,4 @@ jobs:
         ruby-version: ${{ matrix.ruby-version }}
         bundler-cache: true
     - name: Ruby linter
-      run: bundle exec rubocop
+      run: bundle exec rubocop -f github

Rakefile

@@ -11,7 +11,7 @@ task default: [:rubocop, 'test:ruby']
 require 'rake/testtask'
 namespace :test do
   desc %(Run all tests)
-  task all: [:rubocop, 'test:ruby', 'test:js']
+  task all: [:rubocop, :lint_javascript, 'test:ruby', 'test:js']
 
   desc %(Test Ruby code)
   Rake::TestTask.new(:ruby) do |test|
@@ -53,6 +53,11 @@ namespace :test do
   end
 end
 
+desc %(Lint JavaScript files)
+task :lint_javascript do
+  run_pnpm_script 'eslint'
+end
+
 desc %(Regenerate JavaScript files)
 task :regenerate_javascript do
   run_pnpm_script 'build'

dist/client-side-validations.esm.js

@@ -697,7 +697,7 @@ function isAMD() {
   return typeof define === 'function' && define.amd; // eslint-disable-line no-undef
 }
 function isCommonJS() {
-  return (typeof exports === "undefined" ? "undefined" : _typeof(exports)) === 'object' && typeof module !== 'undefined'; // eslint-disable-line no-undef
+  return (typeof exports === "undefined" ? "undefined" : _typeof(exports)) === 'object' && typeof module !== 'undefined';
 }
 
 export { ClientSideValidations as default };

dist/client-side-validations.js

@@ -701,7 +701,7 @@
     return typeof define === 'function' && define.amd; // eslint-disable-line no-undef
   }
   function isCommonJS() {
-    return (typeof exports === "undefined" ? "undefined" : _typeof(exports)) === 'object' && typeof module !== 'undefined'; // eslint-disable-line no-undef
+    return (typeof exports === "undefined" ? "undefined" : _typeof(exports)) === 'object' && typeof module !== 'undefined';
   }
 
   return ClientSideValidations;

eslint.config.mjs

@@ -0,0 +1,13 @@
+import neostandard from 'neostandard'
+
+export default [
+  {
+    ignores: [
+      'coverage/**/*.js',
+      'dist/**/*.js',
+      'test/**/*.js',
+      'vendor/**/*.js',
+    ]
+  },
+  ...neostandard()
+]

package.json

@@ -18,7 +18,7 @@
   },
   "homepage": "https://github.com/DavyJonesLocker/client_side_validations",
   "scripts": {
-    "build": "standard --verbose && rollup -c",
+    "build": "rollup -c",
     "test": "test/javascript/run-qunit.mjs"
   },
   "devDependencies": {
@@ -27,10 +27,11 @@
     "@rollup/plugin-babel": "^6.0.4",
     "@rollup/plugin-node-resolve": "^15.3.0",
     "chrome-launcher": "^1.1.2",
+    "eslint": "^9.12.0",
+    "neostandard": "^0.11.6",
     "puppeteer-core": "^23.5.3",
     "rollup": "^4.24.0",
-    "rollup-plugin-copy": "^3.5.0",
-    "standard": "^17.1.2"
+    "rollup-plugin-copy": "^3.5.0"
   },
   "peerDependencies": {
     "jquery": ">= 1.12.4 < 4.0.0"

src/index.js

@@ -216,7 +216,7 @@ function isAMD () {
 }
 
 function isCommonJS () {
-  return typeof exports === 'object' && typeof module !== 'undefined' // eslint-disable-line no-undef
+  return typeof exports === 'object' && typeof module !== 'undefined'
 }
 
 export default ClientSideValidations

test/javascript/run-qunit.mjs

@@ -25,9 +25,11 @@ export default (async () => {
     return new Promise(resolve => setTimeout(resolve, ms))
   }
 
+  let browser
+
   try {
     const chromeExecutablePath = chromeLauncher.Launcher.getInstallations()[0]
-    const browser = await puppeteer.launch({ executablePath: chromeExecutablePath, headless: 'new' })
+    browser = await puppeteer.launch({ executablePath: chromeExecutablePath, headless: 'new' })
     const page = await browser.newPage()
 
     // Attach to browser console log events, and log to node console

vendor/assets/javascripts/rails.validations.js

@@ -701,7 +701,7 @@
     return typeof define === 'function' && define.amd; // eslint-disable-line no-undef
   }
   function isCommonJS() {
-    return (typeof exports === "undefined" ? "undefined" : _typeof(exports)) === 'object' && typeof module !== 'undefined'; // eslint-disable-line no-undef
+    return (typeof exports === "undefined" ? "undefined" : _typeof(exports)) === 'object' && typeof module !== 'undefined';
   }
 
   return ClientSideValidations;