Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlserver] run sqlserver test in non-utc timezone #19135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lu-zhengda
Copy link
Contributor

@lu-zhengda lu-zhengda commented Nov 25, 2024

What does this PR do?

This PR introduces a new test suite to run SQL Server integration tests in non-UTC time zones. The suite runs SQL Server 2022 on Linux in the America/New_York and Asia/Tokyo time zones. Other tests will continue to default to UTC.

SQLServer timezone is set to non UTC by setting env var TZ in docker compose. Below is an example of setting TZ=America/New_York

docker exec -it compose-sqlserver-1 date
Tue Nov 26 10:42:23 EST 2024

Motivation

The goal is to improve the stability of SQL Server integration tests by proactively identifying and addressing bugs caused by time zone discrepancies.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (c82a811) to head (7522125).
Report is 7 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 91.13% <ø> (+9.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lu-zhengda
Copy link
Contributor Author

Verified setting env var TZ does change the sqlserver container timezone

docker exec -it compose-sqlserver-1 date
Tue Nov 26 10:42:23 EST 2024

@lu-zhengda lu-zhengda added changelog/no-changelog qa/skip-qa Automatically skip this PR for the next QA labels Nov 26, 2024
@lu-zhengda lu-zhengda marked this pull request as ready for review November 26, 2024 15:59
@lu-zhengda lu-zhengda requested review from a team as code owners November 26, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants