Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert lz4 bump #11749

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Revert lz4 bump #11749

merged 1 commit into from
Mar 29, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 29, 2022

What does this PR do?

Revert lz4 bump

Motivation

python-lz4/python-lz4#244, which breaks our Omnibus build

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #11749 (c3db876) into master (7dd8265) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
clickhouse 95.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek merged commit b9b05b1 into master Mar 29, 2022
@ofek ofek deleted the mx-psi/revert-lz4-bump branch March 29, 2022 18:05
@ofek ofek mentioned this pull request Mar 31, 2022
4 tasks
@mx-psi
Copy link
Member Author

mx-psi commented May 5, 2022

So that things are cross-linked, the root cause of the build issue we had with lz4 turned out to be an Omnibus bug: chef/omnibus/issues/1066

@ofek
Copy link
Contributor

ofek commented May 5, 2022

Are we fixing in our fork?

@mx-psi
Copy link
Member Author

mx-psi commented May 5, 2022

Are we fixing in our fork?

I created AP-1659 on JIRA to track this. I have a good idea of what the fix would entail, but if this is not urgently needed I would rather wait until we have some answer from upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants