-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Data Access Control #26492
base: master
Are you sure you want to change the base?
Add Data Access Control #26492
Conversation
Preview links (active after the
|
b76858f
to
6917125
Compare
6917125
to
272b2b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @urseberry this looks good! I have some suggestions mostly for wording and flow and trying to be consistent with capitalizing or not capitalizing Restricted Dataset. Also I think the Supported and not supported examples could benefit from a little bit of re-formatting, but feel free to keep it as is!
Co-authored-by: Alicia Scott <[email protected]>
I'm doing the changes in batches to make them easier to reason about. Will come back later to address the rest of the feedback. |
Co-authored-by: Alicia Scott <[email protected]>
Co-authored-by: Alicia Scott <[email protected]>
What does this PR do? What is the motivation?
Merge instructions
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes