Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing GraphQL tests on .NET Core 2.1 on alpine #5075

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

andrewlock
Copy link
Member

Summary of changes

Bump the version of Microsoft.AspNetCore used to workaround a segfault in libuv

Reason for change

When we increased the size of the CI runners we somehow inadvertently started triggering a segfault in libuv, which only happened on .NET Core 2.1 no alpine, on the GraphQL2 tests

Implementation details

Kevin identified it as a segfault in libuv but the symbols aren't available, so we couldn't do much more. But then we noticed this is the only app running with 2.0.0, and bumping it fixed it so 🤷

Test coverage

This should fix it

Other details

I noticed that HotChocolate also uses 2.0.0, although as that doesn't target .NET Core 2.1, I think it's a bug, so removed it entirely.

@andrewlock andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests labels Jan 17, 2024
@andrewlock andrewlock requested a review from a team as a code owner January 17, 2024 15:17
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 17, 2024

Datadog Report

Branch report: andrew/ci/fix-graphql
Commit report: 719275c
Test service: dd-trace-dotnet

✅ 0 Failed, 303459 Passed, 998 Skipped, 54m 7.42s Wall Time
⌛ 3 Performance Regressions

⌛ Performance Regressions vs Default Branch (3)

  • Baseline_contention - scenarios 1.02s (+9.7ms, +1%) - Details
  • Profiler_contention_cpu_walltime - scenarios 1.75s (+434.76ms, +33%) - Details
  • Profiler_contention - scenarios 1.51s (+236.33ms, +19%) - Details

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5075) - mean (73ms)  : 62, 85
     .   : milestone, 73,
    master - mean (70ms)  : 63, 78
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (5075) - mean (1,028ms)  : 1005, 1050
     .   : milestone, 1028,
    master - mean (1,030ms)  : 1013, 1048
     .   : milestone, 1030,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5075) - mean (107ms)  : 104, 111
     .   : milestone, 107,
    master - mean (106ms)  : 103, 109
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (5075) - mean (735ms)  : 718, 752
     .   : milestone, 735,
    master - mean (736ms)  : 718, 755
     .   : milestone, 736,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5075) - mean (90ms)  : 87, 93
     .   : milestone, 90,
    master - mean (90ms)  : 88, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (5075) - mean (690ms)  : 665, 716
     .   : milestone, 690,
    master - mean (694ms)  : 673, 714
     .   : milestone, 694,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5075) - mean (189ms)  : 186, 192
     .   : milestone, 189,
    master - mean (188ms)  : 186, 190
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5075) - mean (1,135ms)  : 1112, 1157
     .   : milestone, 1135,
    master - mean (1,132ms)  : 1110, 1154
     .   : milestone, 1132,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5075) - mean (273ms)  : 268, 278
     .   : milestone, 273,
    master - mean (271ms)  : 268, 275
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (5075) - mean (1,086ms)  : 1069, 1104
     .   : milestone, 1086,
    master - mean (1,089ms)  : 1062, 1115
     .   : milestone, 1089,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5075) - mean (262ms)  : 258, 265
     .   : milestone, 262,
    master - mean (261ms)  : 258, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (5075) - mean (1,057ms)  : 1034, 1080
     .   : milestone, 1057,
    master - mean (1,050ms)  : 1029, 1071
     .   : milestone, 1050,

Loading

@andrewlock andrewlock merged commit 7608f71 into master Jan 17, 2024
52 of 55 checks passed
@andrewlock andrewlock deleted the andrew/ci/fix-graphql branch January 17, 2024 16:38
@github-actions github-actions bot added this to the vNext milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants