-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: one ./MistServer binary that contains everything #195
Open
iameli
wants to merge
24
commits into
DDVTECH:development
Choose a base branch
from
livepeer:eli/one-binary
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iameli
force-pushed
the
eli/one-binary
branch
2 times, most recently
from
May 19, 2024 18:26
b3d5aa8
to
8fca97c
Compare
this is not very portable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terrible code. Proof-of-concept only. Doesn't work yet. But it does make one binary that boots a few things! Build the new
ninja MistServer
target to try it out.Notes:
MistController MistOutHLS MistOutHTTP MistOutRTMP MistInBuffer MistSession
. So far only RTMP input and output work, HTTP is busted. Capabilities discovery is presently limited to some hardcoded JSON strings; you'd probably want to do codegen on that so capabilities can just be hardcoded at compile time.execvp
themselves to prependUtil::getMyPath() + "MistServer"
. I assume the right path here would be to refactor all of those calls to use the same helper inprocs.h
so that can just be hardcoded/IFDEF'd in one place.ninja MistServer
target is broken on that branch, so there's obviously quite a bit of work to do on setting things up so that they can all be individual modules or one shared thing.