Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more license mappings #213

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

tmehnert
Copy link
Contributor

I have added more license mappings. I would appreciate if you could take a look at the PR.

This PR Resolve #212

Signed-off-by: Torsten Mehnert <[email protected]>
@stevespringett
Copy link
Member

Thanks for the PR. @msymons any concerns?

@msymons
Copy link
Contributor

msymons commented Jun 21, 2022

The concern about mapping of "The BSD License" to BSD-4-Clause rather than to BSD-4-Clause has not yet been resolved. See #205 with my comment added 5th June 2022.

For new mappings added in this PR I would say "Looks OK but I do not have examples to hand to judge otherwise".

One thing I can see in my Dependency-Track v4.6.0 SNAPSHOT, displaying BOMs generated by latest version of cyclonedx-maven-plugin is that it is very visible when a mapping has not YET been done. Here is one example:

"ASF 2.0", which should map to Apache-2.0

Example: https://repo1.maven.org/maven2/cglib/cglib-parent/3.3.0/cglib-parent-3.3.0.pom

I also see unmapped:

  • GNU Lesser Public License
  • GNU LESSER GENERAL PUBLIC LICENSE

...but how far do you want to go with mapping? ie, would it be useful for me to dig out additional examples?

Signed-off-by: Torsten Mehnert <[email protected]>
@tmehnert
Copy link
Contributor Author

I have added the mapping for "ASF 2.0". Proven by example cglib and imgscalr. If some of the mappings in the PR are unclear, i can provide additional examples too. What's your opinion to go further?

@tmehnert
Copy link
Contributor Author

grafik

I think GNU Lesser ... Licenses have to many ambiguities to map them safely. See in screenshot of SPDX License List. Do you agree?

@tmehnert
Copy link
Contributor Author

tmehnert commented Jul 19, 2022

@stevespringett it would be nice, if we can get this PR done. If any concerns left, just tell me and i will do more research as you wish.

@stevespringett
Copy link
Member

Thanks again for the PR @tmehnert. Much appreciated.

@stevespringett stevespringett merged commit a414bea into CycloneDX:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More licenses need to be recognized
3 participants