Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SBOMs for proton-bridge #9

Merged
merged 2 commits into from
May 16, 2021

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented May 16, 2021

As of cyclonedx-gomod v0.6.0, generated SBOMs include license information. I also added SBOMs for another version of proton-bridge to address #5.

@stevespringett
Copy link
Member

Looks like the SBOMs are invalid. A license can be either a resolved SPDX license ID or an unresolved license name, but not both.

Refer to

https://cyclonedx.org/docs/1.2/#type_licenseType

https://cyclonedx.org/use-cases/#license-compliance

nscuro added a commit to CycloneDX/cyclonedx-gomod that referenced this pull request May 16, 2021
identified here: CycloneDX/bom-examples#9 (comment)

also added a validation step to the `bom` target in Makefile, so issues like that are discovered in CI.

Signed-off-by: nscuro <[email protected]>
@nscuro
Copy link
Member Author

nscuro commented May 16, 2021

Thanks for pointing that out @stevespringett. I created a fix and will update this PR once GitHub Actions is working again.

@nscuro
Copy link
Member Author

nscuro commented May 16, 2021

SBOMs have been regenerated with v0.6.1 of cyclonedx-gomod, which includes a fix for the issue. All SBOMs have been validated using the CDX CLI.

@stevespringett
Copy link
Member

Thanks @nscuro. Validated all four. Looks good and thanks for the PR.

@stevespringett stevespringett merged commit b338b2a into CycloneDX:master May 16, 2021
@nscuro nscuro deleted the update-proton-bridge-examples branch May 16, 2021 21:19
stevespringett added a commit that referenced this pull request Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants