OrderlyPrivate authentication & signature, and order update #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanwu4321
reviewed
Aug 15, 2023
| }; | ||
|
|
||
| /** | ||
| * Implements OKEx V3 WebSocket API as defined in |
alanwu4321
reviewed
Aug 15, 2023
| * | ||
| * @param subscriptionId | ||
| * @param channel | ||
| * @see https://www.okx.com/docs-v5/en/#websocket-api-private-channel-order-channel |
alanwu4321
reviewed
Aug 15, 2023
| sendThrottleMs?: number; | ||
| }; | ||
|
|
||
| /** |
|
also clean up functions that are not used |
|
Hi Alan, I've updated the comments and cleaned up some functions. Let me know if you have further feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrderlyPrivateClient: