Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SessionAffinity to PGBouncer Service #3643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add SessionAffinity to PGBouncer Service #3643

wants to merge 1 commit into from

Conversation

Pluggi
Copy link

@Pluggi Pluggi commented May 4, 2023

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

N/A

What is the new behavior (if this is a feature change)?

  • It just adds a parameter to the PostgresCluster CRD so that we can set the sessionAffinity.

Other Information:

jmckulk
jmckulk requested changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@jmckulk jmckulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. We would like some more details before making this change.

Can you provide details about your specific use case? Are you seeing any issues where you need session affinity for pgbouncer?

config/crd/bases/postgres-operator.crunchydata.com_pgupgrades.yaml
@@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.8.0
controller-gen.kubebuilder.io/version: v0.6.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this so that it matches the correct current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmckulk jmckulk jmckulk requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pluggi @jmckulk @tony-landreth