Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and fix PressingBehaviour.java #7168

Open
wants to merge 13 commits into
base: mc1.20.1/dev
Choose a base branch
from

Conversation

Shroopy
Copy link

@Shroopy Shroopy commented Nov 24, 2024

PressingBehaviour now no longer idles for two ticks when doing logic, always works in direct proportion to speed at 75/128 * speed items per second, instead of 12/((59*speed/512)+1) items per second, and doesn't drop partial cycles at the end of a cycle.

@IThundxr IThundxr added pr type: fix PR fixes a bug pr flag: simple PR has minimal changes labels Nov 24, 2024
@Shroopy
Copy link
Author

Shroopy commented Nov 24, 2024

I might be wrong about this actually, don't merge just yet (though I assume it'll be a bit anyways)

@Shroopy Shroopy marked this pull request as draft November 27, 2024 09:28
@Shroopy Shroopy changed the title Fix off by 1 error in PressingBehaviour.java Refactor and fix PressingBehaviour.java Nov 27, 2024
@Shroopy Shroopy marked this pull request as ready for review November 27, 2024 23:23
@IThundxr IThundxr removed the pr flag: simple PR has minimal changes label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr type: fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants