-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and fix PressingBehaviour.java #7168
Open
Shroopy
wants to merge
13
commits into
Creators-of-Create:mc1.20.1/dev
Choose a base branch
from
Shroopy:Shroopy-patch-1
base: mc1.20.1/dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+49
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IThundxr
added
pr type: fix
PR fixes a bug
pr flag: simple
PR has minimal changes
labels
Nov 24, 2024
I might be wrong about this actually, don't merge just yet (though I assume it'll be a bit anyways) |
Shroopy
force-pushed
the
Shroopy-patch-1
branch
from
November 27, 2024 01:38
5572bd4
to
008111a
Compare
Shroopy
force-pushed
the
Shroopy-patch-1
branch
from
November 27, 2024 23:21
243d04a
to
65d9152
Compare
Shroopy
changed the title
Fix off by 1 error in PressingBehaviour.java
Refactor and fix PressingBehaviour.java
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PressingBehaviour now no longer idles for two ticks when doing logic, always works in direct proportion to speed at 75/128 * speed items per second, instead of 12/((59*speed/512)+1) items per second, and doesn't drop partial cycles at the end of a cycle.