Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mismatch go version for github ci #427

Conversation

tungleanh0902
Copy link
Contributor

No description provided.

@tungleanh0902 tungleanh0902 changed the title fix: mismatch go version for github checking fix: mismatch go version for github ci Jan 23, 2024
@hoank101 hoank101 enabled auto-merge January 23, 2024 08:15
auto-merge was automatically disabled January 23, 2024 08:23

Head branch was pushed to by a user without write access

@hoank101 hoank101 enabled auto-merge January 23, 2024 08:23
auto-merge was automatically disabled January 23, 2024 08:27

Head branch was pushed to by a user without write access

@tungleanh0902 tungleanh0902 force-pushed the fix/githubcheck branch 2 times, most recently from f51ddbe to f5c293a Compare January 23, 2024 08:39
@hoank101 hoank101 enabled auto-merge January 23, 2024 08:40
auto-merge was automatically disabled January 23, 2024 08:45

Head branch was pushed to by a user without write access

@tungleanh0902 tungleanh0902 force-pushed the fix/githubcheck branch 3 times, most recently from b8f5684 to 42806fb Compare January 23, 2024 11:03
@hoank101 hoank101 self-requested a review January 23, 2024 11:28
Copy link
Contributor

@kkast kkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it changed to go 1.20 and 1.21 in different cases

@tungleanh0902
Copy link
Contributor Author

My mistake, I accidentally change it to 1.21. Just fix it to 1.20

@tungleanh0902 tungleanh0902 force-pushed the fix/githubcheck branch 2 times, most recently from 15bf65d to 49b7ff2 Compare January 24, 2024 02:38
Copy link
Collaborator

@hoank101 hoank101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoank101 hoank101 disabled auto-merge January 24, 2024 03:04
@hoank101 hoank101 enabled auto-merge January 24, 2024 03:04
auto-merge was automatically disabled January 24, 2024 03:42

Pull request was closed

@tungleanh0902
Copy link
Contributor Author

Already fix on pull request #426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants