-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create locker.yml #2348
Create locker.yml #2348
Conversation
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 suggestions.
- name: Run Locker | ||
uses: ./actions/locker | ||
with: | ||
daysSinceClose: ${{ fromJson(inputs.daysSinceClose || 1) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of 'fromJson' is unnecessary for 'inputs.daysSinceClose' as it is already a string. It should be simplified to '${{ inputs.daysSinceClose || '1' }}'.
daysSinceClose: ${{ fromJson(inputs.daysSinceClose || 1) }} | |
daysSinceClose: ${{ inputs.daysSinceClose || '1' }} |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
uses: ./actions/locker | ||
with: | ||
daysSinceClose: ${{ fromJson(inputs.daysSinceClose || 1) }} | ||
daysSinceUpdate: ${{ fromJson(inputs.daysSinceUpdate || 1) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of 'fromJson' is unnecessary for 'inputs.daysSinceUpdate' as it is already a string. It should be simplified to '${{ inputs.daysSinceUpdate || '1' }}'.
daysSinceUpdate: ${{ fromJson(inputs.daysSinceUpdate || 1) }} | |
daysSinceUpdate: ${{ inputs.daysSinceUpdate || '1' }} |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Thanks Vlad! What do you think about the Co Pilot review? I'm cool with merging this despite the build errors since those will be fixed when we merger #2215. |
@brminnick, I copied the file from the .NET MAUI repo. Let's merge it (and check if it works). I will also try to apply Copilot suggestions with the next PR. |
Auto Lock issues 1 day after close