Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create locker.yml #2348

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Create locker.yml #2348

merged 1 commit into from
Nov 17, 2024

Conversation

VladislavAntonyuk
Copy link
Collaborator

Auto Lock issues 1 day after close

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 suggestions.

- name: Run Locker
uses: ./actions/locker
with:
daysSinceClose: ${{ fromJson(inputs.daysSinceClose || 1) }}
Copy link
Preview

Copilot AI Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of 'fromJson' is unnecessary for 'inputs.daysSinceClose' as it is already a string. It should be simplified to '${{ inputs.daysSinceClose || '1' }}'.

Suggested change
daysSinceClose: ${{ fromJson(inputs.daysSinceClose || 1) }}
daysSinceClose: ${{ inputs.daysSinceClose || '1' }}

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
uses: ./actions/locker
with:
daysSinceClose: ${{ fromJson(inputs.daysSinceClose || 1) }}
daysSinceUpdate: ${{ fromJson(inputs.daysSinceUpdate || 1) }}
Copy link
Preview

Copilot AI Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of 'fromJson' is unnecessary for 'inputs.daysSinceUpdate' as it is already a string. It should be simplified to '${{ inputs.daysSinceUpdate || '1' }}'.

Suggested change
daysSinceUpdate: ${{ fromJson(inputs.daysSinceUpdate || 1) }}
daysSinceUpdate: ${{ inputs.daysSinceUpdate || '1' }}

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@brminnick
Copy link
Collaborator

Thanks Vlad! What do you think about the Co Pilot review?

I'm cool with merging this despite the build errors since those will be fixed when we merger #2215.

@VladislavAntonyuk
Copy link
Collaborator Author

@brminnick, I copied the file from the .NET MAUI repo. Let's merge it (and check if it works). I will also try to apply Copilot suggestions with the next PR.

@brminnick brminnick merged commit 871e1e6 into main Nov 17, 2024
6 of 9 checks passed
@brminnick brminnick deleted the VladislavAntonyuk-patch-1 branch November 17, 2024 20:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants