Allow configuring the notification security code from envs (#64)

CommerceWeavers · Oct 7, 2024 · e660409 · e660409
2 parents 4901882 + b972398
commit e660409
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/config/config/sylius_fixtures.php b/config/config/sylius_fixtures.php
@@ -59,6 +59,8 @@
                     'gatewayConfig' => [
                         'client_id' => '%env(string:TPAY_CLIENT_ID)%',
                         'client_secret' => '%env(string:TPAY_CLIENT_SECRET)%',
+                        'cards_api' => '%env(string:TPAY_CARDS_API)%',
+                        'notification_security_code' => '%env(string:TPAY_NOTIFICATION_SECURITY_CODE)%',
                         'type' => 'redirect',
                         'production_mode' => false,
                     ],
@@ -76,6 +78,7 @@
                         'client_id' => '%env(string:TPAY_CLIENT_ID)%',
                         'client_secret' => '%env(string:TPAY_CLIENT_SECRET)%',
                         'cards_api' => '%env(string:TPAY_CARDS_API)%',
+                        'notification_security_code' => '%env(string:TPAY_NOTIFICATION_SECURITY_CODE)%',
                         'type' => 'card',
                         'production_mode' => false,
                     ],
@@ -93,6 +96,7 @@
                         'client_id' => '%env(string:TPAY_CLIENT_ID)%',
                         'client_secret' => '%env(string:TPAY_CLIENT_SECRET)%',
                         'type' => 'blik',
+                        'notification_security_code' => '%env(string:TPAY_NOTIFICATION_SECURITY_CODE)%',
                         'production_mode' => false,
                     ],
                     'channels' => [
@@ -109,6 +113,7 @@
                         'client_id' => '%env(string:TPAY_CLIENT_ID)%',
                         'client_secret' => '%env(string:TPAY_CLIENT_SECRET)%',
                         'type' => 'pay-by-link',
+                        'notification_security_code' => '%env(string:TPAY_NOTIFICATION_SECURITY_CODE)%',
                         'production_mode' => false,
                     ],
                     'channels' => [

diff --git a/config/services.php b/config/services.php
@@ -12,6 +12,7 @@
         ->set('env(TPAY_CLIENT_ID)', '')
         ->set('env(TPAY_CLIENT_SECRET)', '')
         ->set('env(TPAY_CARDS_API)', '')
+        ->set('env(TPAY_NOTIFICATION_SECURITY_CODE)', '')
         ->set('commerce_weavers_tpay.payum.create_transaction.success_route', 'sylius_shop_order_thank_you')
         ->set('commerce_weavers_tpay.payum.create_transaction.error_route', 'sylius_shop_order_thank_you')
         ->set('commerce_weavers_tpay.payum.create_transaction.notify_route', 'commerce_weavers_tpay_payment_notification')

diff --git a/tests/Application/.env b/tests/Application/.env
@@ -40,4 +40,5 @@ PAYUM_CYPHER_KEY=<edit_me>
 TPAY_CLIENT_ID=<edit_me>
 TPAY_CLIENT_SECRET=<edit_me>
 TPAY_CARDS_API=<edit_me>
+TPAY_NOTIFICATION_SECURITY_CODE=<edit_me>
 ###< commerce-weavers/sylius-tpay-plugin ###
diff --git a/tests/Unit/Payum/Action/Api/CreatePayByLinkTransactionActionTest.php b/tests/Unit/Payum/Action/Api/CreatePayByLinkTransactionActionTest.php
@@ -19,7 +19,6 @@
 use Sylius\Component\Core\Model\OrderInterface;
 use Sylius\Component\Core\Model\PaymentInterface;
 use Tpay\OpenApi\Api\Transactions\TransactionsApi;
-use Webmozart\Assert\InvalidArgumentException;
 
 final class CreatePayByLinkTransactionActionTest extends TestCase
 {
@@ -125,11 +124,13 @@ public function test_it_creates_a_payment_and_redirects_to_a_payment_page(): voi
         $payment->setDetails([
             'tpay' => [
                 'transaction_id' => 'tr4ns4ct!0n_id',
-                'payment_url' => 'https://tpay.org/pay',
-                'status' => 'pending',
                 'result' => null,
+                'status' => 'pending',
                 'blik_token' => null,
                 'card' => null,
+                'payment_url' => 'https://tpay.org/pay',
+                'success_url' => null,
+                'failure_url' => null,
             ],
         ])->shouldBeCalled();