Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Readme) #2977

Draft
wants to merge 132 commits into
base: main
Choose a base branch
from
Draft

chore(Readme) #2977

wants to merge 132 commits into from

Conversation

LinKCoding
Copy link
Contributor

Overview

Updating the commands in the readme to reflect Storybook 8 upgrades

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

jakemhiller and others added 30 commits July 1, 2024 14:51
@jakemhiller
remove styleguide
8716a24
@jakemhiller
replace all usage of babel-preset-codecademy
04ad77e
@jakemhiller
add basic babel packages
8ea5743
@jakemhiller
ran nx migrate latest, update node
3301b2b
@jakemhiller
ran migrations
0915da7
@jakemhiller
remove migrations file
e02961d
@jakemhiller
fix all tests for newer react version
d4a9dd4
@jakemhiller
bump node in CI
768a3b5
@jakemhiller
fix build errors
3a908bb
@dreamwasp
Storybook 8 feature branch
81604da
@dreamwasp
Merge remote-tracking branch 'origin/main' into storybook-8
ca64cba
@dreamwasp
try resolving promise errors
380714a
@dreamwasp
fix iconbutton test
07f770c
@dreamwasp
wipe out sb for now
4fe51b4
@dreamwasp
start with empty lib
8f76949
@dreamwasp
add babel config?
c456390
@dreamwasp
add old package.json back
5f63f9b
@dreamwasp
add old babel config
08e23c0
@dreamwasp
leave to show jake
b30d6c7
@dreamwasp
empty storybook, maybe not running
3ec09ed
@dreamwasp
just try with base config
118af4b
@dreamwasp
start adding maybe need packages
7e05cfa
@dreamwasp
try one story
f28a235
@dreamwasp
progress not perfection
e87a30a
@jakemhiller
ci: set correct node version everywhere
57bcd9e
@jakemhiller
chore: separate dev dependencies from production dependencies
0233464
@dreamwasp
Merge remote-tracking branch 'origin/main' into storybook-8
96b8fd0
@dreamwasp
add node changes here
41a5290
@dreamwasp
fix button test failure
84e57ee
@dreamwasp
fix this, what the heck
c19dffb
dreamwasp and others added 22 commits November 7, 2024 11:19
@dreamwasp
Merge branch 'storybook-8-new-styleguide' into storybook-8-stories
3f5626d
@dreamwasp
Merge branch 'storybook-8-stories' into cass-sb-8-layout
6e6b016
@dreamwasp
no gamut-test tests for now
7b0dfab
@dreamwasp
skip selectdropdown tests for now
71a6c85
@dreamwasp
Merge branch 'storybook-8-new-styleguide' into storybook-8-stories
49ce629
@dreamwasp
Merge branch 'storybook-8-stories' into cass-sb-8-layout
2f18ee1
@dreamwasp
await video resolution
3ebe718
@dreamwasp
skip video for now
3d89cad
@dreamwasp
Merge branch 'storybook-8-new-styleguide' into storybook-8-stories
aef584a
@dreamwasp
Merge branch 'storybook-8-stories' into cass-sb-8-layout
bb66220
@dreamwasp
skip last problematic test
86a8df3
@dreamwasp
Merge branch 'storybook-8-new-styleguide' into storybook-8-stories
01cdc80
@dreamwasp
Merge branch 'storybook-8-stories' into cass-sb-8-layout
bc01fd1
@dreamwasp
add source to template
60f03c6
@dreamwasp
Merge branch 'main' into storybook-8
e176900
@dreamwasp
Merge branch 'storybook-8' into storybook-8-new-styleguide
2795125
@dreamwasp
Merge branch 'storybook-8-new-styleguide' into storybook-8-stories
cccac1a
@dreamwasp
Merge branch 'storybook-8-stories' into cass-sb-8-layout
771c571
@dreamwasp
fix Canvas in template
051237a
@dreamwasp
allow static images in storybook 8 (#2973)
f70f499 
* test image stuff

* getting closer

* test dist

* remove asset tests

* test in pr

* tweak some more examples
@dreamwasp
create foundations + layout stories (#2966)
4662aeb 
* create foundations + layout stories
@LinKCoding
updated readme
4af5c0a
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 20, 2024 •
edited
Loading

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit 4af5c0a.
Please verify you are running the latest version of the NxCloud runner.

Check the Nx Cloud Source Control Integration documentation for more information.

Alternatively, you can contact us at [email protected].

Sent with 💌 from NxCloud.

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://673e325a3f71d94674056702--gamut-preview.netlify.app

Deploy Logs

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@LinKCoding LinKCoding changed the base branch from main to cass-sb-8-layout November 20, 2024 19:21
Base automatically changed from cass-sb-8-layout to storybook-8-stories December 9, 2024 21:39
Base automatically changed from storybook-8-stories to storybook-8-new-styleguide December 9, 2024 21:48
Base automatically changed from storybook-8-new-styleguide to storybook-8 December 9, 2024 21:59
Base automatically changed from storybook-8 to main December 13, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LinKCoding @codecademydev @jakemhiller @dreamwasp @aresnik11