build(Tabs): updates reach/tabs #2879
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timjenkins
force-pushed
the
tim--reach-tabs-update
branch
from
f336a3a to
eb12787
Compare
timjenkins
requested review from
jakemhiller and
BandanaKM
and removed request for
jakemhiller
timjenkins
requested review from
LinKCoding and
dreamwasp
and removed request for
BandanaKM
timjenkins
added
dependencies
dreamwasp
reviewed
May 29, 2024
Comment on lines
+56
to
+78
| const transpileModules = ['@reach']; | ||
|
|
||
| // Find existing rule that excludes node_modules | ||
| const nodeModulesRule = config.module.rules?.find((rule: any) => | ||
| rule.exclude?.toString().includes('node_modules') | ||
| ); | ||
| if (nodeModulesRule) { | ||
| // Tell existing rule to not exclude modules that need transpiling | ||
| const newExclude = new RegExp( | ||
| `node_modules/(?!(${transpileModules.join('|')})/).*` | ||
| ); | ||
|
|
||
| if (Array.isArray(nodeModulesRule.exclude)) { | ||
| nodeModulesRule.exclude = [ | ||
| newExclude, | ||
| ...nodeModulesRule.exclude?.filter( | ||
| (exclude: any) => !exclude.toString().includes('node_modules') | ||
| ), | ||
| ]; | ||
| } else { | ||
| nodeModulesRule.exclude = newExclude; | ||
| } | ||
| } |
timjenkins
force-pushed
the
tim--reach-tabs-update
branch
from
eb12787 to
7a29e2d
Compare
timjenkins
force-pushed
the
tim--reach-tabs-update
branch
from
7a29e2d to
b4a272c
Compare
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
jakemhiller
reviewed
Jun 26, 2024
| @@ -10,7 +10,7 @@ | |||
| "@codecademy/gamut-styles": "16.3.0", | |||
| "@codecademy/variance": "0.21.3", | |||
| "@reach/auto-id": "^0.16.0", | |||
There was a problem hiding this comment.
i think we should to bump this too if possible, to avoid having multiple versions in the lockfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates @reach/tabs to version 18, Adds webpack rule for storybook build to transpile @reach modules
PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs