-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.20.2 and add 2 new features #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes needed for your implementation of new swim mechanics.
Other than that, I would like confirmation that this actually works when compiled and installed without FabricAPI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, i though you put it in the wrong section considering the swimming mixin is in the server folder, fixed in the next commit.
Given this, you should probably move the swimming mixin to the correct folder in this PR. Might as well while you are working on this.
Would it be on the server or client side? Server-side seem to be the most useful and was the original mixin, but it also works client side as well so it can be used on servers without the mod. |
Sorry for the lacking clarity, meant to ask you to move the mixin itself to the client mixin directory. It was in the wrong directory because I thought it would be server sided when I was making the mixin, but it is actually client sided because Vehicle movement is handled entirely on the client. |
Going to quickly test it myself before merging |
Thanks a lot for making this PR. I have invited you to join the Members of HorseBuff on modrinth so you can get 10% of the future revenue. |
Changes
Known Issues:
The default hotkey for opening your inventory on a horse conflicts with the default sprint keyFixed in this commit