Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.20.2 and add 2 new features #63

Merged
merged 9 commits into from
Dec 4, 2023
Merged

Conversation

GirlInPurple
Copy link
Contributor

@GirlInPurple GirlInPurple commented Dec 4, 2023

Changes

Known Issues:

  • Line 43 of build.gradle keeps throwing errors when trying to load dependencies. I dont know why its doing that, was it deprecated?
  • The default hotkey for opening your inventory on a horse conflicts with the default sprint key Fixed in this commit

@GirlInPurple GirlInPurple marked this pull request as draft December 4, 2023 03:38
@GirlInPurple GirlInPurple marked this pull request as ready for review December 4, 2023 03:58
Copy link
Owner

@CodeF53 CodeF53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes needed for your implementation of new swim mechanics.

Other than that, I would like confirmation that this actually works when compiled and installed without FabricAPI.

build.gradle Outdated Show resolved Hide resolved
src/main/java/net/F53/HorseBuff/config/ModConfig.java Outdated Show resolved Hide resolved
src/main/java/net/F53/HorseBuff/mixin/Server/Swim.java Outdated Show resolved Hide resolved
src/main/java/net/F53/HorseBuff/mixin/Server/Swim.java Outdated Show resolved Hide resolved
src/main/java/net/F53/HorseBuff/mixin/Server/Swim.java Outdated Show resolved Hide resolved
src/main/resources/fabric.mod.json Outdated Show resolved Hide resolved
Copy link
Owner

@CodeF53 CodeF53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, i though you put it in the wrong section considering the swimming mixin is in the server folder, fixed in the next commit.

Given this, you should probably move the swimming mixin to the correct folder in this PR. Might as well while you are working on this.

@GirlInPurple
Copy link
Contributor Author

Would it be on the server or client side? Server-side seem to be the most useful and was the original mixin, but it also works client side as well so it can be used on servers without the mod.

@CodeF53
Copy link
Owner

CodeF53 commented Dec 4, 2023

Would it be on the server or client side? Server-side seem to be the most useful and was the original mixin, but it also works client side as well so it can be used on servers without the mod.

Sorry for the lacking clarity, meant to ask you to move the mixin itself to the client mixin directory.

It was in the wrong directory because I thought it would be server sided when I was making the mixin, but it is actually client sided because Vehicle movement is handled entirely on the client.

@CodeF53
Copy link
Owner

CodeF53 commented Dec 4, 2023

Going to quickly test it myself before merging

@CodeF53
Copy link
Owner

CodeF53 commented Dec 4, 2023

The undead horse config option has the label of the normal horse config option

javaw_meiJgvPmdO

Default config option for inventory open modifier is malformed, pressing alt+e doesn't work with it.

javaw_2KKzKFShf9

src/main/resources/assets/horsebuff/lang/en_us.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/main/java/net/F53/HorseBuff/ClientInit.java Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@CodeF53 CodeF53 merged commit 00d0464 into CodeF53:1.20 Dec 4, 2023
@CodeF53
Copy link
Owner

CodeF53 commented Dec 4, 2023

Thanks a lot for making this PR.

I have invited you to join the Members of HorseBuff on modrinth so you can get 10% of the future revenue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants