Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Physick & Garratt Roughness Sublayer Model #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Physick & Garratt Roughness Sublayer Model #82

wants to merge 1 commit into from

Conversation

akshaysridhar
Copy link
Member

@akshaysridhar akshaysridhar commented Jan 12, 2023 •
edited by gdecker1
Loading

To-do

  • Numerical integration (e.g. use QuadGK) in solution (currently DeRidder's analytical approximation is used)
  • Tests consistent with PG95 literature.
  • Code structure following dispatch patterns used elsewhere within SurfaceFluxes
  • I have read and checked the items on the review checklist.

@codecov
Copy link

codecov bot commented Jan 12, 2023 •
edited
Loading

Codecov Report

Patch coverage: 97.91% and project coverage change: +0.97% 🎉

Comparison is base (70741aa) 91.10% compared to head (06ac26a) 92.07%.

❗ Current head 06ac26a differs from pull request most recent head 3b51936. Consider uploading reports for the commit 3b51936 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   91.10%   92.07%   +0.97%     
==========================================
  Files           3        3              
  Lines         787      833      +46     
==========================================
+ Hits          717      767      +50     
+ Misses         70       66       -4
Files Changed Coverage Δ
src/SurfaceFluxes.jl 85.58% <97.91%> (+3.35%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akshaysridhar akshaysridhar mentioned this pull request Jan 13, 2023
Closed
9 tasks
LenkaNovak
LenkaNovak reviewed Jan 13, 2023
View reviewed changes
Copy link

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Akshay, this looks good. I left a few comments. Mostly minor, but I did notice the included test potentially produces some unexpected results. Lmk if you want to connect offline.

src/SurfaceFluxes.jl Show resolved Hide resolved
src/SurfaceFluxes.jl Outdated Show resolved Hide resolved
src/test_pg_1995.jl Outdated Show resolved Hide resolved
@gdecker1 gdecker1 self-assigned this Jul 11, 2023
@gdecker1 gdecker1 linked an issue Jul 18, 2023 that may be closed by this pull request
Roughness Sublayer Models #84
Open
5 tasks
charleskawczynski
charleskawczynski reviewed Jul 24, 2023
View reviewed changes
test/test_rsl.jl Outdated Show resolved Hide resolved
charleskawczynski
charleskawczynski reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reduce the code duplication in this PR a bit? It'll make maintenance easier.

charleskawczynski
charleskawczynski requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@charleskawczynski charleskawczynski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .svg figures from this PR. Also, we'll want to at least squash the commits such that the .svg files do not appear in the commit history.

@charleskawczynski
Copy link
Member

They can be generated for the docs, but they should not be checked into the repo.

@akshaysridhar akshaysridhar mentioned this pull request Aug 14, 2023
Closed
@akshaysridhar akshaysridhar force-pushed the as/PG95-rsl branch 4 times, most recently from 219589d to 17364ec Compare August 31, 2023 21:34
@akshaysridhar
modified: Project.toml
3b51936 
	modified:   docs/bibliography.bib
	modified:   docs/make.jl
	new file:   docs/src/SampleProfiles.md
	new file:   docs/src/plot_profiles.jl
	modified:   docs/src/plot_universal_functions.jl
	modified:   src/SurfaceFluxes.jl
	modified:   test/runtests.jl
	modified:   test/test_profiles.jl
	new file:   test/test_rsl.jl
	modified:   test/test_universal_functions.jl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmdeck kmdeck kmdeck left review comments

@LenkaNovak LenkaNovak LenkaNovak left review comments

@charleskawczynski charleskawczynski charleskawczynski requested changes

Assignees

@gdecker1 gdecker1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Roughness Sublayer Models
6 participants
@akshaysridhar @charleskawczynski @LenkaNovak @kmdeck @cmbengue @gdecker1