-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open halo filling on Windowed fields #3834
base: main
Are you sure you want to change the base?
Conversation
How does this PR address #3833 |
There was a missing offset that was preventing filling the open halos for windowed fields correctly |
Put a comment in the code on the key lines to prevent the problem from happening again. This PR only fixes the code but does not address the underlying issue that it's easy to miss the need for that. |
size = fill_halo_size(field, regular_fill, indices, boundary_conditions, loc, grid) | ||
offset = fill_halo_offset(size, regular_fill, indices) | ||
params = KernelParameters(size, offset) | ||
|
||
launch!(arch, grid, params, open_fill, field, left_bc, right_bc, loc, grid, args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard for me to tell how what these changes do so a comment would help.
Should close #3833. Probably, we can wait to merge #3792 before this one and add some tests for fill halo regions here