Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge semiautomatic_task_paused into manual_pause_mowing #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rovo89
Copy link
Contributor

@rovo89 rovo89 commented Jul 22, 2024

Only tested in simulator so far. The intention is to reduce the variety of different state holders for what seems to be the same thing. Allows to reset that "pause" via dynamic param update without forcefully starting the next mowing trip (which command_start() would do). I'll create this as a draft PR in case I missed some situation where two different "variables" are required.

rovo89 referenced this pull request Jul 22, 2024
@rovo89 rovo89 force-pushed the semiauto_pause_merge branch from f22a80e to f87fc74 Compare July 26, 2024 19:54
@rovo89
Copy link
Contributor Author

rovo89 commented Jul 26, 2024

Re-done after the formatting changes.

@olliewalsh I think you mentioned using manual_pause_mowing frequently. Would these changes contradict your use-cases?

@rovo89
Copy link
Contributor Author

rovo89 commented Aug 15, 2024

Just noticed that this PR was still in draft state. I tested the functionality again with the real mower and could confirm my impression from the simulator. Pressing "Home" while mowing sets manual_pause_mowing (and obviously returns to the docking station). The mower doesn't leave again until either the parameter is set back to false or if the "Start" button was pressed (which resets manual_pause_mowing, but also sets a flag to start irrespectively of the battery level).

@rovo89 rovo89 marked this pull request as ready for review August 15, 2024 22:59
@rovo89
Copy link
Contributor Author

rovo89 commented Aug 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant