-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Palemoon and closes old issues if not needed #2332
Conversation
If you want any of the closing issues removed please tell me. |
Actually quite like the idea of closing these issues, but I'm torn about, if this should be its own PR to be fully separated from any meaningful code changes. Edit: |
With the new PR Template if filled in correctly will close issues when PR's are merged. |
Also you can just do a PR with closing issues you have to make a change that is why I added that program. |
Yeah, you're right, didn't think about that, but nevertheless, i think, the part after Edit: from my first comment still applies |
And the 180+ discussions still stay open for all eternity... |
I will find something out for discussions to help sort the issue. |
A good point. I'm currently not on a pro or enterprise plan (free github) and the permission controls are rather terrible. I'm thinking a github action would be a good workaround to clean up some of these that can handle some of the permissions. |
Pull Request
Title
Adds Palemoon and closes old issues if not needed
Type of Change
Description
Adds Palemoon browser to applications.json file and closes issues that have been fixed or issues that have been made that are not needed/necessary.
Testing
I have tested to make sure the program installs and shows in the UI.
Impact
Adds a program to Applications.json and closes old issues to clear them out.
Issue related to PR
[What issue is related to this PR (if any)]
Additional Information
No
Checklist
Closes old PR's due to being fixed and sorted
Closes #2189
Closes #2206
Closes #2232
Closes #2243
Closes #2249
Closes #2097
Closes #2318