Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Palemoon and closes old issues if not needed #2332

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Real-MullaC
Copy link
Contributor

@Real-MullaC Real-MullaC commented Jul 11, 2024

Pull Request

Title

Adds Palemoon and closes old issues if not needed

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Adds Palemoon browser to applications.json file and closes issues that have been fixed or issues that have been made that are not needed/necessary.

Testing

I have tested to make sure the program installs and shows in the UI.

Impact

Adds a program to Applications.json and closes old issues to clear them out.

Issue related to PR

[What issue is related to this PR (if any)]

Additional Information

No

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Closes old PR's due to being fixed and sorted

Closes #2189
Closes #2206
Closes #2232
Closes #2243
Closes #2249
Closes #2097
Closes #2318

@Real-MullaC
Copy link
Contributor Author

If you want any of the closing issues removed please tell me.

@Marterich
Copy link
Contributor

Marterich commented Jul 11, 2024

Actually quite like the idea of closing these issues, but I'm torn about, if this should be its own PR to be fully separated from any meaningful code changes.

Edit:
All in all this is still a workaround and it's not really feasible in the long term to moderate the issues and discussion this way. IMHO @ChrisTitusTech should at least think about adding some kind of permission system to allow some contributers to help moderate (close, Tag and assign) the issues, discussion (and maybe revitalize the project feature)
I'm fine with Chris being the only one to merge PRs, but I think this would greatly improve the project and make it easier for contributers to find open problems, current problems as well as users when searching for previous issues and solutions

@Real-MullaC
Copy link
Contributor Author

Actually quite like the idea of closing these issues, but I'm torn about, if this should be its own PR to be fully separated from any meaningful code changes.

Edit: All in all this is still a workaround and it's not really feasible in the long term to moderate the issues and discussion this way. IMHO @ChrisTitusTech should at least think about adding some kind of permission system to allow some contributers to help moderate (close, Tag and assign) the issues, discussion (and maybe revitalize the project feature) I'm fine with Chris being the only one to merge PRs, but I think this would greatly improve the project and make it easier for contributers to find open problems, current problems as well as users when searching for previous issues and solutions

With the new PR Template if filled in correctly will close issues when PR's are merged.

@Real-MullaC
Copy link
Contributor Author

Also you can just do a PR with closing issues you have to make a change that is why I added that program.

@Marterich
Copy link
Contributor

Also you can just do a PR with closing issues you have to make a change that is why I added that program.

Yeah, you're right, didn't think about that, but nevertheless, i think, the part after Edit: from my first comment still applies

@Real-MullaC
Copy link
Contributor Author

Also you can just do a PR with closing issues you have to make a change that is why I added that program.

Yeah, you're right, didn't think about that, but nevertheless, i think, the part after Edit: from my first comment still applies

image

@Marterich
Copy link
Contributor

Marterich commented Jul 11, 2024

Also you can just do a PR with closing issues you have to make a change that is why I added that program.

Yeah, you're right, didn't think about that, but nevertheless, i think, the part after Edit: from my first comment still applies

image

And the 180+ discussions still stay open for all eternity...
Also, not every issue or discussion will lead to a merged pr...

@Real-MullaC
Copy link
Contributor Author

Also you can just do a PR with closing issues you have to make a change that is why I added that program.

Yeah, you're right, didn't think about that, but nevertheless, i think, the part after Edit: from my first comment still applies

image

And the 180+ discussions still stay open for all eternity...

I will find something out for discussions to help sort the issue.

@ChrisTitusTech
Copy link
Owner

Actually quite like the idea of closing these issues, but I'm torn about, if this should be its own PR to be fully separated from any meaningful code changes.

Edit: All in all this is still a workaround and it's not really feasible in the long term to moderate the issues and discussion this way. IMHO @ChrisTitusTech should at least think about adding some kind of permission system to allow some contributers to help moderate (close, Tag and assign) the issues, discussion (and maybe revitalize the project feature) I'm fine with Chris being the only one to merge PRs, but I think this would greatly improve the project and make it easier for contributers to find open problems, current problems as well as users when searching for previous issues and solutions

A good point. I'm currently not on a pro or enterprise plan (free github) and the permission controls are rather terrible. I'm thinking a github action would be a good workaround to clean up some of these that can handle some of the permissions.

@ChrisTitusTech ChrisTitusTech merged commit 8cfd47e into ChrisTitusTech:main Jul 15, 2024
@Real-MullaC Real-MullaC deleted the Adds-Palemoon branch July 15, 2024 08:01
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
3 participants