Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement #572

Merged
merged 12 commits into from
Oct 5, 2024
Merged

Enhancement #572

merged 12 commits into from
Oct 5, 2024

Conversation

jinningwang
Copy link
Member

@jinningwang jinningwang commented Oct 4, 2024

Several enhancements for following issues:

Equivalent star bus of three-winding transformer: #571

Clarify PFlow solution: #570

Add a method get_all_idxes() to group: #568,

Allow all matches in find_idx(): #566 (comment)

@jinningwang
Copy link
Member Author

@cuihantao I think it's ready to merge

andes/models/group.py Outdated Show resolved Hide resolved
andes/routines/pflow.py Outdated Show resolved Hide resolved
@jinningwang
Copy link
Member Author

Have addressed your concerns accordingly.

@jinningwang
Copy link
Member Author

@cuihantao any more suggestions? If looks good we can merge it.

@cuihantao
Copy link
Collaborator

Thanks! Merging in a second.

@cuihantao cuihantao merged commit 2b17faa into CURENT:develop Oct 5, 2024
3 checks passed
@jinningwang jinningwang deleted the enhance branch October 5, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants