adding LODF and GLODF code #449
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear RyanVaughan, Thanks a lot for your contribution. Before we finally merge it, I have two comments:
|
cuihantao
requested changes
May 8, 2023
andes/routines/glodf.py
Outdated
| A[l,self.system.Line.bus2.v[l]-1] = 1 | ||
|
|
||
| # delete all slack rows as required | ||
| Ar = np.delete(A, np.asarray(self.system.Slack.bus.v)-1, axis=1) |
There was a problem hiding this comment.
This line will fail if self.system.Slack.bus.v contains non-numerical values. Slack.bus.v contains references to bus idxes, which are not guaranteed numerals.
You can call self.system.Bus.idx2uid(self.system.Slack.bus.v) to retrieve 0-based index of the Slack bus id.
andes/routines/glodf.py
Outdated
| change_lines = np.atleast_1d(change_lines) | ||
| psi = self.get_isf() | ||
|
|
||
| slack = np.array(self.system.Slack.bus.v) |
There was a problem hiding this comment.
A similar issue here. Consider generalizing it.
andes/routines/glodf.py
Outdated
Comment on lines
100
to
101
| bfrom = np.asarray(self.system.Line.bus1.v)[change_lines - 1] | ||
| bto = np.asarray(self.system.Line.bus2.v)[change_lines - 1] |
There was a problem hiding this comment.
Problem with these indices.
|
Considering it is more like a steady state analysis, I add similar functionalities in AMS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial request to merge generalized line outage distribution factor (GLODF) code. Let me know of any feedback.