Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Nodes/BG Client section #57

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

andrealbiac
Copy link
Contributor

Hello! Uploading a PR for a new section to include in the main BG site, about the Node/ bg Client.

It's a bit provisional cause as I understand the main goal is to redesign the whole BG site sooner than later, but just shipping this quickly to have it there in the meantime C:

It's supposed to look like this:
Captura de pantalla 2024-12-02 a las 15 48 58

so it's still missing:

  • the lines that go all the way to the limits of the section (can't seem to get it done even with the IA)
  • and a small tweak to make the pink and green section stretch all the way (also can't find the issue- but I'm looking into it).
  • button copy is not great

Also maybe Hunter can give me a little frontend hand for these :) And open to any feedback, thank you!
PD: First PR after the long holidays so I hope it's not very messy :p

Copy link

vercel bot commented Dec 2, 2024

@andrealbiac is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

@andrealbiac andrealbiac changed the title Created section and added content New Nodes/BG Client section Dec 2, 2024
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buidlguidl-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 5:16pm

Copy link
Contributor

@ChangoMan ChangoMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some initial feedback for the quick fixes I see

packages/nextjs/pages/index.tsx Outdated Show resolved Hide resolved
packages/nextjs/pages/index.tsx Outdated Show resolved Hide resolved
@andrealbiac
Copy link
Contributor Author

Thanks @ChangoMan ! The fixes were very helpful, just updated them. Will update on the lines as a last step 👍🏻

@andrealbiac andrealbiac requested a review from ChangoMan December 4, 2024 13:19
@andrealbiac
Copy link
Contributor Author

So I was able to add the lines, and also thought the image of the satellite was not necessary on mobile version when both images were stacked, so I hid it, and made the other section green in return.

Now looks like this:
Captura de pantalla 2024-12-04 a las 14 00 19
Captura de pantalla 2024-12-04 a las 14 00 06

Let me know if you still see anything weird please! :)

@andrealbiac andrealbiac removed the request for review from carletex December 4, 2024 13:23
packages/nextjs/pages/index.tsx Outdated Show resolved Hide resolved
packages/nextjs/pages/index.tsx Show resolved Hide resolved
@austintgriffith austintgriffith merged commit e611653 into BuidlGuidl:main Dec 4, 2024
1 of 2 checks passed
@andrealbiac andrealbiac deleted the nodes-section branch December 5, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants