Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3. Fevicon,Logo,Subtitle Chnaged #24

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

Vedant-05
Copy link

Description

Have updated the fevicon & logo to the new batch 11 Logo , changed Subtitle to batch 11's moto, added an SVG icon for the subtitle. Attaching the ss for the same .

New Logo:
logo

Current Batch 11 Header
Screenshot 2024-11-28 at 4 20 23 PM

Additional Information

Related Issues

Closes #8

Your ENS/address:
0xc4Ad6218B68514161fFeC5dA54E1D30462C27CCD

Copy link

vercel bot commented Nov 28, 2024

Someone is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

@Vedant-05
Copy link
Author

Should we change the title of the page also from "Scaffold-ETH 2 App" to "BuidlGuidl-Batch-11" ??

Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice logo! Thanks for the PR.

Just a little request below :)

packages/nextjs/components/Header.tsx Show resolved Hide resolved
@Vedant-05
Copy link
Author

I have chnaged the title for the website , and committed it to this pr , can you review it once ?

@phipsae
Copy link
Collaborator

phipsae commented Nov 29, 2024

Thanks! Lets merge

@phipsae phipsae merged commit aa00808 into BuidlGuidl:main Nov 29, 2024
0 of 2 checks passed
@phipsae
Copy link
Collaborator

phipsae commented Nov 29, 2024

@Vedant-05 Could you please merge with latest main branch and push again. We ran in some weird eslint error while deploying to vercel (has nothing to do with your code).

@Vedant-05
Copy link
Author

Hey sorry i didn't get you ,
Do i need to take a pull from the repo , then merge my title one branch in my fork repos main branch and then create a new pull request to the main repo's main branch ?

@phipsae
Copy link
Collaborator

phipsae commented Nov 29, 2024

Or maybe could you try to push that again to github first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3. Change the Logo / title / subtitle
2 participants