-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add personal builder page #18
Conversation
@gboigwe is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the page!
Below you'll find some little comments.
As a tip for the next PR, you could consider implement a screenshot of the page (more complex a video). That's easier for the maintainer to jump into the review
packages/nextjs/app/builders/0x5cc8Be96B1C9A68F57a73b5bEa60cF5D890055A1/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x5cc8Be96B1C9A68F57a73b5bEa60cF5D890055A1/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x5cc8Be96B1C9A68F57a73b5bEa60cF5D890055A1/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x5cc8Be96B1C9A68F57a73b5bEa60cF5D890055A1/page.tsx
Outdated
Show resolved
Hide resolved
Personal Builder PageDescriptionAdded my personal builder page with the following features:
ScreenshotsAdditional Notes
|
Enhanced Homepage and Builders GridChanges Made
Implementation Details
ScreenshotsThe checked in count:The builders profile grid:
Testing Done
Additional Notes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes and also the implementation of builders overview!
Unfortunately that has nothing to do with your personal page PR, pls take that out and create a dedicated PR for that.
Thanks a lot!
Please confirm now that the PR has only solved the issue pertaining to it. Thank you |
Perfect, no its good, thanks! Lets merge! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you, It's a real great relief comment. Thanks. |
Description
Added some information about me
Additional Information
Related Issues
Closes #{2}
Your ENS/address: 0x5cc8Be96B1C9A68F57a73b5bEa60cF5D890055A1