Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add personal builder page #18

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Conversation

gboigwe
Copy link
Contributor

@gboigwe gboigwe commented Nov 19, 2024

Description

Added some information about me

Additional Information

Related Issues

Closes #{2}

Your ENS/address: 0x5cc8Be96B1C9A68F57a73b5bEa60cF5D890055A1

Copy link

vercel bot commented Nov 19, 2024

@gboigwe is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the page!

Below you'll find some little comments.

As a tip for the next PR, you could consider implement a screenshot of the page (more complex a video). That's easier for the maintainer to jump into the review

@gboigwe
Copy link
Contributor Author

gboigwe commented Nov 20, 2024

Personal Builder Page

Description

Added my personal builder page with the following features:

  • Responsive design for mobile and desktop
  • Dark/light mode support
  • Enhanced typography and visual hierarchy
  • Social links integration
  • Address display using SE2 components

Screenshots

image

Additional Notes

  • Implemented all feedback from previous review
  • Used existing Scaffold-ETH 2 components
  • Maintained consistent styling with the project

@gboigwe
Copy link
Contributor Author

gboigwe commented Nov 20, 2024

Enhanced Homepage and Builders Grid

Changes Made

  • ✨ Improved homepage dark mode visibility and contrast
  • 🏗️ Added BuildersGrid component showing registered builders
  • 🔄 Created API route to fetch builder addresses from filesystem
  • 🔗 Connected grid to personal builder pages (/builders/0x...)
  • 💅 Updated styling and layout for better UX

Implementation Details

  • Homepage now reads checkedInCounter from BatchRegistry contract
  • BuildersGrid scans filesystem for builder pages in /builders directory
  • Added loading states and error handling
  • Maintained consistent styling with existing components

Screenshots

The checked in count:

image

The builders profile grid:

image

  • For now I only have mine, but if this PR is accepted and merged, then every builder would be registered in.

Testing Done

  • Tested dark mode visibility
  • Verified builder count display
  • Confirmed grid updates when new builder pages are added
  • Checked mobile responsiveness

Additional Notes

  • Grid automatically updates as builders add their profile pages
  • Uses existing Address component for consistency

Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes and also the implementation of builders overview!

Unfortunately that has nothing to do with your personal page PR, pls take that out and create a dedicated PR for that.

Thanks a lot!

packages/nextjs/app/page.tsx Outdated Show resolved Hide resolved
packages/nextjs/components/batch/BuildersGrid.tsx Outdated Show resolved Hide resolved
packages/nextjs/app/api/builders/route.ts Outdated Show resolved Hide resolved
@gboigwe
Copy link
Contributor Author

gboigwe commented Nov 22, 2024

Please confirm now that the PR has only solved the issue pertaining to it. Thank you

@phipsae
Copy link
Collaborator

phipsae commented Nov 24, 2024

Perfect, no its good, thanks! Lets merge!

@phipsae phipsae merged commit ab937a0 into BuidlGuidl:main Nov 24, 2024
1 check failed
Copy link

vercel bot commented Nov 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch11.buidlguidl.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2024 2:35am

@gboigwe
Copy link
Contributor Author

gboigwe commented Nov 24, 2024

Perfect, no its good, thanks! Lets merge!

Thank you, It's a real great relief comment. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants