Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing badges for members - for issue #5 #15

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

melanke
Copy link
Contributor

@melanke melanke commented Nov 18, 2024

Description

Showing badges at the header for when the user is a Batch11 builder and another badge for when the user completed the checkin.
image

Additional Information

Related Issues

Closes #5

Your ENS/address:
0x2Bc096A12C5b37F035180aDeF70EB2B88351e5B8

Copy link

vercel bot commented Nov 18, 2024

@melanke is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

@melanke melanke changed the title Showing badges for members Showing badges for members - for issue #5 Nov 18, 2024
@phipsae phipsae self-requested a review November 21, 2024 06:35
Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation and I like that you use the header, thanks!

Just a little comment below. Let me know what you think.

packages/nextjs/components/UserBadges.tsx Outdated Show resolved Hide resolved
@melanke
Copy link
Contributor Author

melanke commented Nov 21, 2024

I've made the changes, now it can be on 4 different states:

  • Disconnected:
    image

  • Not a member:
    image

  • Member without checking
    I couldn't test this case. As I asked on Telegram:

    do you know if it's possible to add a Watch Account on MetaMask (or another wallet) and connect with this Watch Account to test how the interface would behave with this user? Obviously I wouldn't be able to sign a transaction but the page would show the info as this user.

  • Checked in:
    image

Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice implementation, Good job!

Just a little tiny comment below and then we merge.

packages/nextjs/components/UserBadges.tsx Outdated Show resolved Hide resolved
@phipsae phipsae self-requested a review November 23, 2024 12:14
@phipsae
Copy link
Collaborator

phipsae commented Nov 23, 2024

Nice implementation! Thanks a lot!

@phipsae phipsae merged commit 33eb3cf into BuidlGuidl:main Nov 23, 2024
1 of 2 checks passed
Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch11.buidlguidl.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 0:24am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6. Show connected wallet info
2 participants