Add setToken API for OAuthBearer authentication flow #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewstanovsky
force-pushed
the
astanovsky/oauthbearer_set_token
branch
from
7d339f7
to
3ec6942
Compare
andrewstanovsky
force-pushed
the
astanovsky/oauthbearer_set_token
branch
from
3ec6942
to
826b98d
Compare
mpodwysocki
reviewed
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds new setToken API based on librdkafka's one to allow node-rdkafka clients authenticate using OAuthBearer flow. SetToken accepts token string only, no expiry is expected as it's always set to maximum value with librdkafka at C++ level. The client code is supposed to call setToken again to refresh a token when needed. The expiry is used in refresh callback flow of librdkafka which is not used in this change to avoid complexity.