Phpunit 6 compatibility #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 5.4 and 5.5 are not maintained anymore.
soullivaneuh
force-pushed
the
phpunit-6
branch
from
d9f6792 to
f1636d3
Compare
soullivaneuh
force-pushed
the
phpunit-6
branch
2 times, most recently
from
88df57d to
9cb58e0
Compare
The old one throws notices on PHP 7.
soullivaneuh
force-pushed
the
phpunit-6
branch
from
1b4ed4b to
12eda35
Compare
|
@stof Failing HHVM seems to be not related. The last master build is form over 2 years now, maybe you can try a new trigger? |
|
I propose to remove HHVM support, because in my opinion support for phpunit 6 is most important. |
|
@soullivaneuh I did a pull request huge upgrades. Use Phpunit 6.5 and remove HHVM are parts of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a quite easy-pick and can be release under a new minor because of the PHP version dropping.