Refactor boinc.json structure a little bit. #5947
Merged
+144
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (14)
- installer/Control.cpp: Language not supported
- installer/Control.h: Language not supported
- installer/ControlTable.cpp: Language not supported
- installer/Installer.cpp: Language not supported
- installer/InstallerStrings.cpp: Language not supported
- installer/InstallerStrings.h: Language not supported
- installer/RadioButton.cpp: Language not supported
- installer/RadioButton.h: Language not supported
- installer/RadioButtonTable.cpp: Language not supported
- installer/RadioButtonTable.h: Language not supported
- installer/boinc.json: Language not supported
- installer/locale/en.json: Language not supported
- installer/main.cpp: Language not supported
- win_build/installer_setup.vcxproj: Language not supported
This was
linked to
issues
Dec 12, 2024
Moved RadioButton definitions closer to the relevant controls. Locale files now shoulw be defined in the main JSON file. Add possibility to pass main JSON file as a parameter to the installer.exe. Signed-off-by: Vitalii Koshura <[email protected]>
AenBleidd
force-pushed
the
vko_msi_refactor
branch
from
2255872 to
6b45a98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved RadioButton definitions closer to the relevant controls.
Locale files now should be defined in the main JSON file.
Add possibility to pass main JSON file as a parameter to the installer.exe.