fix problem where wrapper unzips input files each time it restarts #5938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client: set up slot dir only at start of job.
This is a little tricky because of async file copy.
Deal with this by creating a 'boinc_setup_complete' file
after all files are copied.
These fixes address a problem where:
- wrapper job starts, unzips its output files, deletes the .zip
- job stops (e.g. client exits)
- job restarts; client sees that .zip file isn't in slot dir,
copies it again.
- wrapper starts, unzips .zip file again.
The fixes address both (new client, old wrapper) and (old client, new wrapper).
AenBleidd
approved these changes
Dec 7, 2024
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (7)
- client/app.h: Language not supported
- client/app_control.cpp: Language not supported
- client/app_start.cpp: Language not supported
- client/client_state.cpp: Language not supported
- client/client_state.h: Language not supported
- client/main.cpp: Language not supported
- samples/wrapper/wrapper.cpp: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5936
wrapper: unzip input files only first time we run
client: set up slot dir only at start of job.
This is a little tricky because of async file copy.
Deal with this by creating a 'boinc_setup_complete' file
after all files are copied.
These fixes address a problem where:
copies it again.
The fixes address both (new client, old wrapper) and (old client, new wrapper).