Improve Repository Structure #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trsvchn
changed the title
trsvchn
force-pushed
the
refactor_repo_structure
branch
from
3f31d0e
to
8305fbe
Compare
trsvchn
force-pushed
the
refactor_repo_structure
branch
from
d639666
to
08ceb26
Compare
trsvchn
changed the title
|
Merge for now, add tests later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will
Add 2 new modules:
modules(formermodels_shared): contains basic modulesmodelswith end-to-end modelsMotivation: Classes in models_shared are torch modules and not self contained models, they are building blocks, more appropriate term is modules. In a future every shareable module goes here.