-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tenantId info in Data Explorer while opening from Portal #1987
Conversation
…m/Azure/cosmos-explorer into users/sindhuba/activate-prod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will conflict with #1940 and for Fabric I'm not sure right now if we will have a tenant ID, so for now it should be optional.
In my PR we do a silent login request here: https://github.com/Azure/cosmos-explorer/pull/1940/files#diff-3cb2c099721b88f13e1e81ad91e978f408b30798c2b3be969c7122b863a0d721R92-R95, it should carry a user_hint
(in addition to tenantId from Portal) to allow silent sign in and optionally the tenant ID as proposed here.
If no tenantId is provided, it should fall back to the tenant ID from the MSAL account as it happens here: https://github.com/Azure/cosmos-explorer/pull/1940/files#diff-3cb2c099721b88f13e1e81ad91e978f408b30798c2b3be969c7122b863a0d721R135
This is basically very similar to the unfinished task in my PR, so let's do it all together.
This has been addressed in a separate PR. |
This has been addressed in a separate PR. |
Preview this branch