Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tenantId info in Data Explorer while opening from Portal #1987

Merged
merged 48 commits into from
Oct 9, 2024

Conversation

sindhuba
Copy link
Collaborator

@sindhuba sindhuba commented Oct 3, 2024

sindhuba and others added 30 commits March 18, 2024 10:25
@sindhuba sindhuba requested a review from a team as a code owner October 3, 2024 13:27
Copy link
Contributor

@sevoku sevoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will conflict with #1940 and for Fabric I'm not sure right now if we will have a tenant ID, so for now it should be optional.

In my PR we do a silent login request here: https://github.com/Azure/cosmos-explorer/pull/1940/files#diff-3cb2c099721b88f13e1e81ad91e978f408b30798c2b3be969c7122b863a0d721R92-R95, it should carry a user_hint (in addition to tenantId from Portal) to allow silent sign in and optionally the tenant ID as proposed here.

If no tenantId is provided, it should fall back to the tenant ID from the MSAL account as it happens here: https://github.com/Azure/cosmos-explorer/pull/1940/files#diff-3cb2c099721b88f13e1e81ad91e978f408b30798c2b3be969c7122b863a0d721R135

This is basically very similar to the unfinished task in my PR, so let's do it all together.

@sindhuba
Copy link
Collaborator Author

sindhuba commented Oct 8, 2024

This will conflict with #1940 and for Fabric I'm not sure right now if we will have a tenant ID, so for now it should be optional.

In my PR we do a silent login request here: https://github.com/Azure/cosmos-explorer/pull/1940/files#diff-3cb2c099721b88f13e1e81ad91e978f408b30798c2b3be969c7122b863a0d721R92-R95, it should carry a user_hint (in addition to tenantId from Portal) to allow silent sign in and optionally the tenant ID as proposed here.

If no tenantId is provided, it should fall back to the tenant ID from the MSAL account as it happens here: https://github.com/Azure/cosmos-explorer/pull/1940/files#diff-3cb2c099721b88f13e1e81ad91e978f408b30798c2b3be969c7122b863a0d721R135

This is basically very similar to the unfinished task in my PR, so let's do it all together.

This has been addressed in a separate PR.

@sindhuba sindhuba closed this Oct 8, 2024
@sindhuba sindhuba reopened this Oct 8, 2024
@sindhuba sindhuba requested a review from sevoku October 8, 2024 22:16
@sindhuba
Copy link
Collaborator Author

sindhuba commented Oct 8, 2024

This will conflict with #1940 and for Fabric I'm not sure right now if we will have a tenant ID, so for now it should be optional.

In my PR we do a silent login request here: https://github.com/Azure/cosmos-explorer/pull/1940/files#diff-3cb2c099721b88f13e1e81ad91e978f408b30798c2b3be969c7122b863a0d721R92-R95, it should carry a user_hint (in addition to tenantId from Portal) to allow silent sign in and optionally the tenant ID as proposed here.

If no tenantId is provided, it should fall back to the tenant ID from the MSAL account as it happens here: https://github.com/Azure/cosmos-explorer/pull/1940/files#diff-3cb2c099721b88f13e1e81ad91e978f408b30798c2b3be969c7122b863a0d721R135

This is basically very similar to the unfinished task in my PR, so let's do it all together.

This has been addressed in a separate PR.

@sindhuba sindhuba changed the title Support multi-tenant switching for Data Plane RBAC Add tenantId info in Data Explorer while opening from Portal Oct 8, 2024
@sindhuba sindhuba removed the request for review from sevoku October 8, 2024 23:00
@jawelton74 jawelton74 merged commit ac2e2a6 into master Oct 9, 2024
37 checks passed
@jawelton74 jawelton74 deleted the users/sindhuba/multi-tenant branch October 9, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants