Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle size reports to the PR description #5280

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

Leah-Xia-Microsoft
Copy link
Member

@Leah-Xia-Microsoft Leah-Xia-Microsoft commented Oct 8, 2024

What

  • Add/update the bundle size reports to the bottom of the PR description
  • Remove the bundle size comments
  • Block PR if the bundle size change is greater than the significant threshold and no tag is added

Why

How Tested

  • After adding a testing commit to increase the bundle size, the chat bundle size has been updated in the description.
    image

  • And the CI job fails with the correct error message
    image

  • After adding the significant bundle size change label, the bundleSizeCheck step is ignored and the CI job passes
    image

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Calling bundle size is not changed.

  • Current size: 8139366
  • Base size: 8139366
  • Diff size: 0

CallWithChat bundle size is not changed.

  • Current size: 8139379
  • Base size: 8139379
  • Diff size: 0

Chat bundle size is decreased✅.

  • Current size: 1757266
  • Base size: 1757267
  • Diff size: -1

Copy link
Contributor

github-actions bot commented Oct 8, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26875 / 43178
62.24%
26875 / 43178
62.24%
733 / 1340
54.7%
2127 / 3416
62.26%
Current 26815 / 43178
62.1%
26815 / 43178
62.1%
733 / 1340
54.7%
2143 / 3416
62.73%
Diff -60 / 0
-0.14%
-60 / 0
-0.14%
0 / 0
0%
16 / 0
0.47%

Copy link
Contributor

github-actions bot commented Oct 8, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 53787 / 88010
61.11%
53787 / 88010
61.11%
1093 / 2486
43.96%
3207 / 5311
60.38%
Current 53830 / 88010
61.16%
53830 / 88010
61.16%
1093 / 2486
43.96%
3210 / 5316
60.38%
Diff 43 / 0
0.05%
43 / 0
0.05%
0 / 0
0%
3 / 5
0%

@Azure Azure deleted a comment from github-actions bot Oct 8, 2024
@Azure Azure deleted a comment from github-actions bot Oct 8, 2024
@Azure Azure deleted a comment from github-actions bot Oct 8, 2024
@Leah-Xia-Microsoft Leah-Xia-Microsoft added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants