-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update check-vulnerabilities.ps1 to error out if dotnet command fails and update build project dependencies #3786
base: main
Are you sure you want to change the base?
Conversation
Hello @kshyju @mattchenderson -- Could you please review this PR? Thank you. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment about next work that should be tracked, but that does not need to block this specific PR.
} | ||
|
||
cd $projectPath | ||
$logFilePath = "$PSScriptRoot/build.log" | ||
foreach ($projectFilePath in $CsprojFilePath) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking aloud, I wonder if we would want to parallelize these upstream of the call into the script, I suppose that's supported by the parameter being included here. But we should probably ensure that gets tracked, as it will be much more efficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with these changes, but I do want to point out with .NET8 SDK this is built into the restore process (configurable via msbuild properties). Additionally, we have component governance running for this repo which will flag these CVEs.
I'm not a big fan of hard failures for CVEs in the pipeline. I prefer being given some time to address the CVEs before all our pipelines are blocked (thus impacting ongoing work).
The base branch was changed.
Issue describing the changes in this PR
This PR contains the following changes:
check-vulnerabilities.ps1
to validate the packages for the following projects are up-to-date:"$PSScriptRoot/src/Azure.Functions.Cli/Azure.Functions.Cli.csproj" "$PSScriptRoot/test/Azure.Functions.Cli.Tests/Azure.Functions.Cli.Tests.csproj"
"$PSScriptRoot/build/Build.csproj"
Build.csproj
Pull request checklist