Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: source setting screens from global #147

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

justlevine
Copy link
Member

What

This PR refactors the frontend package to source the screen titles, menu label, and descriptions from the server via the wpGraphQLLogin.settings global.

Why

So new settings don't need to be manually allow-listed.

How

Provider screen is still manually hydrated until that component gets refactored.

Testing Instructions

Additional Info

Checklist:

  • My code is tested to the best of my abilities.
  • My code follows the WordPress Coding Standards.
  • My code has proper inline documentation.
  • I have added unit tests to verify the code works as intended.
  • I included the relevant changes in CHANGELOG.md

@justlevine justlevine merged commit 4ad07ee into AxeWP:develop Oct 26, 2024
16 of 19 checks passed
@justlevine justlevine deleted the dev/decouple-setting-screens branch October 26, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant