Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model): handle array filters when casting bulkWrite #15036

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fix(model): handle array filters when casting bulkWrite #15036

merged 3 commits into from
Nov 13, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14978

Summary

Right now we don't handle array filters when casting bulkWrite, this PR fixes that

Examples

hasezoey
hasezoey approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though for completeness, shouldnt the array contain something that does not match the filter?

test/model.test.js Outdated Show resolved Hide resolved
@vkarpov15 vkarpov15 merged commit 7aba322 into master Nov 13, 2024
64 checks passed
@vkarpov15 vkarpov15 added this to the 8.8.2 milestone Nov 13, 2024
@hasezoey hasezoey deleted the vkarpov15/gh-14978 branch November 13, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.8.2
Development

Successfully merging this pull request may close these issues.

Model.bulkWrite fails embedded array update with embedded discriminator and arrayFilters
2 participants
@vkarpov15 @hasezoey