Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide EVM address on stakers list #164

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Provide EVM address on stakers list #164

merged 1 commit into from
Nov 19, 2024

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Nov 11, 2024

In this PR I am switching to indexer v14 (using the latest indexer version is not supported any more by SubSquid) and adding EVM address to staker list result

Copy link

Visit the preview URL for this PR (updated for commit 4a2ae6e):

https://astar-token-api--pr164-feat-evm-address-gpv6o9of.web.app

(expires Mon, 18 Nov 2024 11:03:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f99fa4f4f8f3bb450e6e842f7e1c7783d6d896a3

@gtg7784 gtg7784 self-requested a review November 11, 2024 13:04
@@ -12,6 +12,6 @@ export class DappStakingV3IndexerBase extends ServiceBase {

protected getApiUrl(network: NetworkType): string {
// For local development: `http://localhost:4350/graphql`;
return `https://astar-network.squids.live/dapps-staking-indexer-${network}/graphql`;
return `https://astar-network.squids.live/dapps-staking-indexer-${network}/v/v14/graphql`;
Copy link
Member

@gtg7784 gtg7784 Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the v14 to prod in sqd cloud and revert this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because of
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay

@gtg7784 gtg7784 self-requested a review November 12, 2024 09:45
Copy link
Member

@gtg7784 gtg7784 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobo-k2 bobo-k2 merged commit 37aab89 into prod Nov 19, 2024
7 checks passed
@bobo-k2 bobo-k2 deleted the feat/evm-address branch November 19, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants