pmgr: Fix false positive u8 pmgr ID detection on modern SoCs #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc: @asdfugil does this still work on A7 - A11? |
The id1 field used on oder SoCs is not constant 0 for all devices on t8122. Instead just compare the id1 fields of the two first devices. Fixes "pmgr: Failed to find parent AsahiLinux#36 for IOA0\n" errors in pmgr_init(). Fixes: fb59dc0 ("pmgr: Fix struct for older SoCs") Signed-off-by: Janne Grunau <[email protected]>
jannau
force-pushed
the
pmgr_false_positive_u8_id
branch
from
a6b45d3 to
e144abe
Compare
|
Works on A7-A11, T2, so: Reviewed-by: Nick Chan [email protected] |
asdfugil
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The id1 field used on oder SoCs is not constant 0 for all devices on t8122. Instead just compare the id1 fields of the two first devices. Fixes "pmgr: Failed to find parent #36 for IOA0\n" errors in pmgr_init().
Fixes: fb59dc0 ("pmgr: Fix struct for older SoCs")