Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INSTALL.pipeline #514

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

falconkirtaran
Copy link
Contributor

Install instructions to account for new python incompatibility

Install instructions to account for new python incompatibility
INSTALL.pipeline Outdated
Comment on lines 56 to 58
echo 'export PATH="$HOME/.pyenv/bin:$PATH"' >> ~/.bashrc
echo 'export "$(pyenv init -)"' >> ~/.bashrc
echo 'eval "$(pyenv virtualenv-init -)"' >> ~/.bashrc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right. Things changed a bit in pyenv in May (pyenv/pyenv#1898). The background is that PATH modifications belong in ~/.profile, not ~/.bashrc, because the latter may be sourced multiple times. pyenv init does PATH manipulations as well as other things that need to be in ~/.bashrc (namely shell integration via a function). But on some systems, ~/.profile sources ~/.bashrc when invoked from a Bash shell, which makes things even messier...

Here are all the details: https://github.com/pyenv/pyenv#basic-github-checkout

I've never used the installer/pyenv.run, but I think it prints instructions after installation on how to correctly configure things? Can we just refer to those instead of listing it explicitly here?

INSTALL.pipeline Outdated Show resolved Hide resolved
INSTALL.pipeline Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants