Quick Reblog: Reimplement tag suggestion UI #1612
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This manually implements a component similar to the HTML
datalist
element that we're currently using to show the user tag suggestions. This should result in:Does not use the new
<dialog>
element or newpopover
global attribute; I briefly played with both but neither seemed usable for this and the latter lacks browser support. Might be useful for other things, though.At time of writing, the DOM structure and CSS I created are... uh, let's just say "probably improvable." This feels like one of those PRs that could use the "April fixes everything" special.
Testing steps
Confirm that:
Needs further testing for modal logic edge cases. Needs further testing for overflow (e.g. with long suggested tags/many suggested tags).Needs testing onFirefox andreal mobile device; smoke tested on Chrome and Chrome responsive design mode.