fix: RwLock race condition during group controller instantiation #6860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardshiue
force-pushed
the
fix/6816
branch
from
63b00df
to
2d9590a
Compare
richardshiue
force-pushed
the
fix/6816
branch
from
2d9590a
to
17d15e0
Compare
richardshiue
changed the title
richardshiue
force-pushed
the
fix/6816
branch
from
48a057b
to
c3b4d7a
Compare
richardshiue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6816
This fix introduces a regression to the calculation feature. Therefore, another solution needs to be foundSometimes a bug fix is dirty. But sometimes a dirty bug fix works.
The test doesn't pass on main
Feature Preview
PR Checklist