-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetch url meta data on creating row #6130
base: main
Are you sure you want to change the base?
Conversation
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
lint rule | new reports | level | link |
---|---|---|---|
Missing translation | 81 | warning | contribute (via Fink 🐦) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6130 +/- ##
==========================================
+ Coverage 74.41% 75.26% +0.84%
==========================================
Files 245 232 -13
Lines 6566 6828 +262
Branches 1057 964 -93
==========================================
+ Hits 4886 5139 +253
+ Misses 1628 1626 -2
- Partials 52 63 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
At first, I wanted to also enable this feature in grid view on filling URL field, but filling other fields inside The next step can be adding the description and image of URL metadata in the row page. |
After inputting the URL, there's a noticeable delay before the parsed URL is inserted (I understand this is due to fetching metadata). This lag affects the user experience. We should consider a better way to handle this. For example:
@zoli What do you think? |
@LucasXu0 By creating a new item do you mean sending |
What should the behavior be when there are more than one URL fields? |
I can change the settings to choose a specific field, for now, I thought selecting the first URL field type would be good enough. |
@richardshiue will choosing specific field in settings and pseudo card while fetching the URL be enough for this? |
Hi @zoli , please add bloc tests or integration test. |
@appflowy, Added both bloc and integration tests. |
On submitting a new row in board view, if the setting is enabled and the text is a URL fetch url metadata and fill the row with it.
closes #5963
Feature Preview
2024-08-31.00-09-20.mp4
PR Checklist