load test resources #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocsandcoffee
approved these changes
Dec 6, 2022
| actual fun readBinaryResource(resourcePath: String): ByteArray { | ||
| val path = resourcePath.substringBeforeLast(".") | ||
| val fileType = resourcePath.substringAfterLast(".") | ||
| println("resourcePath=$resourcePath, path=$path, fileType=$fileType") |
There was a problem hiding this comment.
Although it's just test, probably can remove debug print statements in this file
There was a problem hiding this comment.
I left it for debugging since it is not due to a flaky CI. It is currently not working for iOS / native.
I read there is another gradle task needed to copy the assets into the build directory.
There was a problem hiding this comment.
You mean the copy task from the article or a different one?
There was a problem hiding this comment.
Yes, I think I haven't added it already.
|
what is the status of this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 What does this PR do?
Load test resources per platform. See this blogpost for implementation details: https://developer.squareup.com/blog/kotlin-multiplatform-shared-test-resources/
✅ Checklist
🧪 How can this PR been tested?
🧾 Tasks Remaining: (List of tasks remaining to be implemented)
🖼️ Screenshots (if applicable):