Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuiltMC port #25

Open
wants to merge 10 commits into
base: 1.19
Choose a base branch
from
Open

QuiltMC port #25

wants to merge 10 commits into from

Conversation

MikolajKolek
Copy link

@MikolajKolek MikolajKolek commented Jul 11, 2022

I saw that you were looking for help in porting the mod to QuiltMC, so I wanted to help. The port seems to work completely fine for me, you can do some more testing to make sure, hovewer I didn't make very significant changes so I doubt anything serious broke.
If you want to go all in on Quilt and make the mod a Quilt exclusive, I could also change the config system from ClothConfig to the new Quilt Config system, the use of which is recommended for Quilt mods. Unfortunately, that would require more significant work as I would have to rewrite the configuration screen, because Quilt Config does not provide a configuration screen by itself (maybe I could use a similar system to OkZoomer as that mod already uses the Quilt Config system and is MIT licenced too, however it uses SpruceUI, don't know if you'd be ok with including a new library).

(Also, sorry for the mess in the commit log, I had to rebase my branch because I realised that merging this into 1.18.2 wouldn't make sense)
(The code analysis says it failed, but in reality it just seems to not be able to run on this branch, so it doesn't even do the analysis)

@Alujjdnd
Copy link
Owner

WOW! Thank you so much for this amazing work (not to mention the quality commented code)! We'll try to merge this with our current repo, and we'll be sure to credit you for this!

Thanks again :)
Alujjdnd and Flooflez

@Flooflez
Copy link
Collaborator

Hi there,
Thanks again for the help, this is something that we couldn't have done ourselves.
Reading your comment, perhaps it's a good idea to wait until Quilt Config is more accessible before creating a full release for Quilt.

Copy link

@ItzSkyReed ItzSkyReed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants