-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuiltMC port #25
base: 1.19
Are you sure you want to change the base?
QuiltMC port #25
Conversation
# Conflicts: # remappedSrc/alujjdnd/ngrok/lan/NgrokServerInitialiser.java
WOW! Thank you so much for this amazing work (not to mention the quality commented code)! We'll try to merge this with our current repo, and we'll be sure to credit you for this! Thanks again :) |
Hi there, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what
I saw that you were looking for help in porting the mod to QuiltMC, so I wanted to help. The port seems to work completely fine for me, you can do some more testing to make sure, hovewer I didn't make very significant changes so I doubt anything serious broke.
If you want to go all in on Quilt and make the mod a Quilt exclusive, I could also change the config system from ClothConfig to the new Quilt Config system, the use of which is recommended for Quilt mods. Unfortunately, that would require more significant work as I would have to rewrite the configuration screen, because Quilt Config does not provide a configuration screen by itself (maybe I could use a similar system to OkZoomer as that mod already uses the Quilt Config system and is MIT licenced too, however it uses SpruceUI, don't know if you'd be ok with including a new library).
(Also, sorry for the mess in the commit log, I had to rebase my branch because I realised that merging this into 1.18.2 wouldn't make sense)
(The code analysis says it failed, but in reality it just seems to not be able to run on this branch, so it doesn't even do the analysis)