Model schema (updated to use DataProcess) #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lDynamics/aind-data-schema into feat-1078-modelschema
makes software_version, parameters optional, allows list for input_location
|
note that one point under discussion here was whether to have separate fields under ModelTraining for hyperparameter search. I had this in an earlier draft, but realized the more straightforward way to represent that might be to have a separate ModelTraining object for hyperparameter optimization and for regular training in cases when both are occurring, with the resulting hyperparameter values stored in the outputs field. |
|
tests are dependent on AllenNeuralDynamics/aind-data-schema-models#107 |
|
Just showed this to Nick and he's on board with the updates @saskiad |
saskiad
reviewed
Dec 7, 2024
saskiad
approved these changes
Dec 7, 2024
This was referenced Dec 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #1078, replacing PR #1109