[Perf] Use heuristics to avoid allocations in Sanitizer::str_till_eol #2517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(transferred from ProvableHQ#6, and asking @d0cd for a review as suggested there)
The
Sanitizer
is used very prominently in our parsing functions, and it is also a source of many allocations, most of which are temporary and avoidable.The potential perf improvements are quite large, and I've measured them both with a 15-minute run of a
--dev
node and usinghyperfine
on a small binary that parsed all the valid.aleo
programs currently present in the snarkVM codebase.dev node:
Program::from_str
specifically, allocs are reduced by ~64%, of which temp allocs ~88%parsing all
.aleo
programs usingProgram::from_str
: