Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump multichain helm chart to latest #9697

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

turadg
Copy link
Member

@turadg turadg commented Jul 12, 2024

Description

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

CI

Upgrade Considerations

none

@turadg turadg added the force:integration Force integration tests to run on PR label Jul 12, 2024
@turadg turadg requested a review from 0xpatrickdev July 12, 2024 16:22
Copy link

cloudflare-workers-and-pages bot commented Jul 12, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2968d3c
Status: ✅  Deploy successful!
Preview URL: https://57e522e6.agoric-sdk.pages.dev
Branch Preview URL: https://ta-bump-multichain-chart.agoric-sdk.pages.dev

View logs

@0xpatrickdev
Copy link
Member

I see you've added force-integration so bumping this convo: #9679 (comment)

Does it trigger Multichain E2E? It doesn't appear to

@turadg turadg force-pushed the ta/bump-multichain-chart branch 2 times, most recently from 2b11c39 to 5f04adc Compare July 19, 2024 18:55
@0xpatrickdev 0xpatrickdev force-pushed the ta/bump-multichain-chart branch from 5f04adc to 330577e Compare July 27, 2024 02:11
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.93%. Comparing base (1875030) to head (4a6b313).
Report is 2 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
SwingSet/kernel 73.36% <ø> (ø)
ERTP 92.45% <ø> (ø)
Orchestration 94.62% <ø> (ø)
swing-store 95.95% <ø> (ø)

see 76 files with indirect coverage changes

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Jul 27, 2024
@turadg
Copy link
Member Author

turadg commented Jul 27, 2024

@mergify rebase

Copy link
Contributor

mergify bot commented Jul 27, 2024

rebase

✅ Branch has been successfully rebased

@turadg turadg force-pushed the ta/bump-multichain-chart branch from 4a6b313 to 2968d3c Compare July 27, 2024 17:13
@turadg turadg requested review from 0xpatrickdev and dckc July 29, 2024 11:44
@0xpatrickdev 0xpatrickdev removed the automerge:rebase Automatically rebase updates, then merge label Jul 29, 2024
Copy link
Member

@0xpatrickdev 0xpatrickdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but removed automerge:rebase as I added another small commit - PTAL at 7ede1e4

@0xpatrickdev
Copy link
Member

0xpatrickdev commented Jul 29, 2024

What the heck! Getting really weird flakes after 7ede1e4 that seem unrelated to the change:

  • 2x Override Chain Registry is failing
  • 2x message: 'Cannot parse value of response for path [data,published.wallet.agoric143vmgvmknf64fua9cf0z9wqqtz8hjzzxh8zt9e.current]: {"value":""}', in auto-stake-it.test.ts

Not observing either on local, but will remove the commit for now.

diff
diff --git a/multichain-testing/config.yaml b/multichain-testing/config.yaml
index 320274650..79c24cbf2 100644
--- a/multichain-testing/config.yaml
+++ b/multichain-testing/config.yaml
@@ -18,12 +18,14 @@ chains:
       updateConfig:
         file: scripts/update-config.sh
     faucet:
-      enabled: false
+      enabled: true
+      type: starship
     ports:
       rest: 1317
       rpc: 26657
       exposer: 38087
       grpc: 9090
+      faucet: 8085
     resources:
       cpu: 1
       memory: 4Gi
diff --git a/multichain-testing/test/tools/wallet.test.ts b/multichain-testing/test/tools/wallet.test.ts
index 8667d5cbc..7fcf24e16 100644
--- a/multichain-testing/test/tools/wallet.test.ts
+++ b/multichain-testing/test/tools/wallet.test.ts
@@ -1,5 +1,6 @@
 import anyTest from '@endo/ses-ava/prepare-endo.js';
 import type { TestFn } from 'ava';
+import type { Denom } from '@agoric/orchestration';
 import { makeQueryClient } from '../../tools/query.js';
 import { createWallet } from '../../tools/wallet.js';
 import { sleep } from '../../tools/sleep.js';
@@ -7,41 +8,41 @@ import { commonSetup } from '../support.js';

 const test = anyTest as TestFn<Record<string, never>>;

-const walletScenario = test.macro(async (t, scenario: string) => {
-  const { useChain } = await commonSetup(t);
-
-  const prefix = useChain(scenario).chain.bech32_prefix;
-  const wallet = await createWallet(prefix);
-  const addr = (await wallet.getAccounts())[0].address;
-  t.regex(addr, new RegExp(`^${prefix}1`));
-  t.log('Made temp wallet:', addr);
-
-  const apiUrl = await useChain(scenario).getRestEndpoint();
-  const queryClient = makeQueryClient(apiUrl);
-  t.log('Made query client');
-
-  const { balances } = await queryClient.queryBalances(addr);
-  t.log('Beginning balances:', balances);
-  t.deepEqual(balances, []);
-
-  const { creditFromFaucet } = useChain(scenario);
-  t.log('Requesting faucet funds');
-
-  await creditFromFaucet(addr);
-  // XXX needed to avoid race condition between faucet POST and LCD Query
-  // see https://github.com/cosmology-tech/starship/issues/417
-  await sleep(1000, t.log);
-
-  const { balances: updatedBalances } = await queryClient.queryBalances(addr);
-  const expectedDenom = scenario === 'osmosis' ? 'uosmo' : 'uatom';
-  t.like(updatedBalances, [{ denom: expectedDenom, amount: '10000000000' }]);
-  t.log('Updated balances:', updatedBalances);
-
-  const bondDenom = useChain(scenario).chain.staking?.staking_tokens?.[0].denom;
-  t.truthy(bondDenom, 'bond denom found');
-  const { balance } = await queryClient.queryBalance(addr, bondDenom!);
-  t.deepEqual(balance, { denom: bondDenom, amount: '10000000000' });
+const walletScenario = test.macro({
+  title: (_, chainName: string, denom: Denom) =>
+    `create a wallet and get ${denom} on ${chainName}`,
+  exec: async (t, chainName: string, denom: Denom) => {
+    const { useChain } = await commonSetup(t);
+
+    const prefix = useChain(chainName).chain.bech32_prefix;
+    const wallet = await createWallet(prefix);
+    const addr = (await wallet.getAccounts())[0].address;
+    t.regex(addr, new RegExp(`^${prefix}1`));
+    t.log('Made temp wallet:', addr);
+
+    const apiUrl = await useChain(chainName).getRestEndpoint();
+    const queryClient = makeQueryClient(apiUrl);
+    t.log('Made query client');
+
+    const { balances } = await queryClient.queryBalances(addr);
+    t.log('Beginning balances:', balances);
+    t.deepEqual(balances, []);
+
+    const { creditFromFaucet } = useChain(chainName);
+    t.log('Requesting faucet funds');
+    await creditFromFaucet(addr, denom);
+    // XXX needed to avoid race condition between faucet POST and LCD Query
+    // see https://github.com/cosmology-tech/starship/issues/417
+    await sleep(1000, t.log);
+
+    const { balance } = await queryClient.queryBalance(addr, denom);
+    t.log('Ending balance:', balance);
+    t.deepEqual(balance, { denom, amount: '10000000000' });
+  },
 });

-test('create a wallet and get tokens (osmosis)', walletScenario, 'osmosis');
-test('create a wallet and get tokens (cosmoshub)', walletScenario, 'cosmoshub');
+test(walletScenario, 'osmosis', 'uosmo');
+test(walletScenario, 'cosmoshub', 'uatom');
+test(walletScenario, 'agoric', 'ubld');
+test(walletScenario, 'agoric', 'uist');
+test(walletScenario, 'osmosis', 'uion');

@0xpatrickdev 0xpatrickdev force-pushed the ta/bump-multichain-chart branch from 7ede1e4 to 2968d3c Compare July 29, 2024 18:02
@0xpatrickdev 0xpatrickdev added the automerge:rebase Automatically rebase updates, then merge label Jul 29, 2024
@mergify mergify bot merged commit 4696a6a into master Jul 29, 2024
157 checks passed
@mergify mergify bot deleted the ta/bump-multichain-chart branch July 29, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants