Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(windows): during installation remove autostart entry before updating/reinstalling, to prevent duplicates #1061

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented May 20, 2024

No idea if this fixes it.


🚀 This description was created by Ellipsis for commit a00b53a

Summary:

This PR updates the activitywatch-setup.iss script to remove existing autostart entries during installation, preventing duplicates.

Key points:

  • Updated activitywatch-setup.iss to remove existing autostart entry during installation.
  • Prevents duplicate autostart entries on reinstall/update.

Generated with ❤️ by ellipsis.dev

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a00b53a in 1 minute and 12 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. scripts/package/activitywatch-setup.iss:67
  • Draft comment:
    Ensure that the deletion of the autostart entry is handled gracefully even if the file does not exist. Consider adding a check or a flag to avoid errors or warnings during the installation process if the file is not found.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_W8fkdYCafGGTgbND


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

8 hours left in your free trial, upgrade for $20/seat/month or contact us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant