Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GH-3229): Update to Spring Boot 2.4.1 #249

Closed
wants to merge 25 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f68e1c5
fix: Update Spring Boot version to 2.4.1
igdianov Dec 14, 2020
3f2319d
fix: Update Spring Cloud version to 2020.0.0-M6
igdianov Dec 14, 2020
4210511
build: add Spring Milestones repository
igdianov Dec 14, 2020
a72853a
fix: use Spring Boot version 2.4.1
igdianov Dec 14, 2020
be32767
build: move Spring Milestones repository to build
igdianov Dec 14, 2020
a957f4c
fix: update deprecated websocket client spec builder
igdianov Dec 14, 2020
887d530
fix: remove SI deprecated classes from messages core module
igdianov Dec 14, 2020
fb4a085
fix: update spring-integration-hazelcast to 3.0.0
igdianov Dec 14, 2020
2064917
fix: add io.projectreactor.addons:reactor-extra module events
igdianov Dec 14, 2020
4f15994
fix: update removed api in graphql-ws
igdianov Dec 14, 2020
3fdd20d
fix: update removed api in graphq-starter test
igdianov Dec 14, 2020
3cce9dd
fix(modeling): set default spring.jackson.dateFormat to yyyy-MM-dd'T'…
igdianov Dec 15, 2020
cb6eae5
fix(rb): set default spring.jackson.dateFormat to yyyy-MM-dd'T'HH:mm:…
igdianov Dec 15, 2020
5c5ed0a
fix: extract default jackson.date-format to activiti-cloud-service-co…
igdianov Dec 15, 2020
bcaff8d
fix: update default date format to yyyy-MM-dd'T'HH:mm:ss.SSSZZZ
igdianov Dec 15, 2020
149189b
fix: set jackson.date-format to yyyy-MM-dd'T'HH:mm:ss.SSSZ
igdianov Dec 15, 2020
5f5c3f7
fix: override StdDateFormat without colon in time zone
igdianov Dec 15, 2020
66914f7
fix: use super constructor for StdDateFormat override
igdianov Dec 15, 2020
1164852
fix(build): add deploy preview to Nexus
igdianov Dec 15, 2020
deb2d24
fix: add SNAPSHOT qualifier to preview version
igdianov Dec 15, 2020
b1e0587
fix(version): update spring-cloud.version to 2020.0.0-RC1
igdianov Dec 15, 2020
a8a6bed
fix(version): update Activiti PR version to 0.0.1-PR-3497-6683-SNAPSHOT
igdianov Dec 16, 2020
00d474e
fix(build): add activiti-snapshots repository
igdianov Dec 16, 2020
b6e89c4
fix(travis): add deploy conditional preview on preview branch prefix
igdianov Dec 18, 2020
e778b51
fix(version): update activiti.version to 0.0.1-PR-3505-6694-SNAPSHOT
igdianov Dec 21, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ env:

stages:
- name: test
- name: deploy_preview
if: type = pull_request AND head_branch =~ ^.*preview$
- name: publish reports
- name: tag_deploy_updatebot
if: type != pull_request
Expand Down Expand Up @@ -49,6 +51,11 @@ jobs:
- name: activiti-cloud-connectors
stage: test
script: ${MAVEN_VERIFY_CMD} -f activiti-cloud-connectors/pom.xml
- name: Deploy Preview
stage: deploy_preview
script: |
mvn versions:set -DnewVersion=$(cat VERSION)-SNAPSHOT -DprocessAllModules=true -DgenerateBackupPoms=false || travis_terminate 1
mvn clean deploy -DskipTests || travis_terminate 1
- name: publish reports
stage: publish reports
before_script: aws s3 sync ${S3_JACCO_DIR} .
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,27 @@

import static org.assertj.core.api.Assertions.assertThat;

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import java.time.Duration;
import java.util.LinkedHashMap;
import java.util.Map;
import java.util.function.Consumer;
import net.thucydides.core.annotations.Step;

import org.activiti.cloud.acc.core.config.RuntimeTestsConfigurationProperties;
import org.activiti.cloud.acc.core.rest.RuntimeDirtyContextHandler;
import org.activiti.cloud.acc.core.rest.feign.EnableRuntimeFeignContext;
import org.activiti.cloud.acc.shared.service.BaseService;
import org.reactivestreams.Subscription;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Qualifier;

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import net.thucydides.core.annotations.Step;
import reactor.core.publisher.Mono;
import reactor.core.publisher.ReplayProcessor;
import reactor.netty.http.client.HttpClient;
import reactor.netty.http.client.HttpClient.WebsocketSender;
import reactor.netty.http.client.WebsocketClientSpec;
import reactor.test.StepVerifier;

@EnableRuntimeFeignContext
Expand All @@ -43,6 +46,9 @@ public class NotificationsSteps {
private static final String GRAPHQL_WS = "graphql-ws";
private static final String AUTHORIZATION = "Authorization";
private static final Duration TIMEOUT = Duration.ofMillis(90000);
private static final WebsocketClientSpec graphqlWsClientSpec = WebsocketClientSpec.builder()
.protocols(GRAPHQL_WS)
.build();

@Autowired
private RuntimeDirtyContextHandler dirtyContextHandler;
Expand All @@ -56,30 +62,30 @@ public class NotificationsSteps {

@Autowired
private ObjectMapper objectMapper;

@Step
public void checkServicesHealth() {
assertThat(baseService.isServiceUp()).isTrue();
}

public String getRuntimeBundleServiceName() {
return properties.getRuntimeBundleServiceName();
}

@SuppressWarnings({"serial"})
@Step
public ReplayProcessor<String> subscribe(String accessToken,
String query,
Map<String,Object> variables,
public ReplayProcessor<String> subscribe(String accessToken,
String query,
Map<String,Object> variables,
Consumer<Subscription> action) throws InterruptedException {
ReplayProcessor<String> data = ReplayProcessor.create();

WebsocketSender client = HttpClient.create()
.wiretap(true)
.headers(h -> h.add(AUTHORIZATION, "Bearer " + accessToken))
.websocket(GRAPHQL_WS)
.websocket(graphqlWsClientSpec)
.uri(properties.getGraphqlWsUrl());

Map<String, Object> json = new LinkedHashMap<String, Object>() {{
put("type", "start");
put("id", "1");
Expand All @@ -95,8 +101,8 @@ public ReplayProcessor<String> subscribe(String accessToken,
} catch (JsonProcessingException e) {
throw new RuntimeException(e);
}


// handle start subscription
client.handle((i, o) -> {
o.sendString(Mono.just(startMessage))
Expand Down Expand Up @@ -125,11 +131,11 @@ public ReplayProcessor<String> subscribe(String accessToken,

@Step
public void verifyData(ReplayProcessor<String> data, String...messages) {

StepVerifier.create(data)
.expectNext(messages)
.expectComplete()
.verify(TIMEOUT);
}

}
2 changes: 1 addition & 1 deletion activiti-cloud-api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<name>Activiti Cloud :: Runtime API Parent</name>
<packaging>pom</packaging>
<properties>
<activiti.version>7.1.279</activiti.version>
<activiti.version>0.0.1-PR-3505-6694-SNAPSHOT</activiti.version>
</properties>
<modules>
<module>activiti-cloud-api-dependencies</module>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<packaging>pom</packaging>
<name>Activiti Cloud :: Dependencies Parent</name>
<properties>
<spring-cloud.version>Hoxton.SR5</spring-cloud.version>
<spring-cloud.version>2020.0.0-RC1</spring-cloud.version>
<testcontainers.version>1.14.2</testcontainers.version>
</properties>
<dependencyManagement>
Expand Down
11 changes: 10 additions & 1 deletion activiti-cloud-build/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,17 @@
<maven-site-plugin.version>3.8.2</maven-site-plugin.version>
<maven-source-plugin.version>3.2.1</maven-source-plugin.version>
<maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version>
<spring-boot.version>2.2.8.RELEASE</spring-boot.version>
<spring-boot.version>2.4.1</spring-boot.version>
</properties>
<modules>
<module>activiti-cloud-build-dependencies-parent</module>
</modules>
<repositories>
<repository>
<id>spring-milestones</id>
<name>Spring Milestones</name>
<url>https://repo.spring.io/milestone</url>
</repository>
<repository>
<id>central</id>
<name>Central Repository</name>
Expand All @@ -218,6 +223,10 @@
<id>activiti-releases</id>
<url>https://artifacts.alfresco.com/nexus/content/repositories/activiti-releases</url>
</repository>
<repository>
<id>activiti-snapshots</id>
<url>https://artifacts.alfresco.com/nexus/content/repositories/activiti-snapshots</url>
</repository>
</repositories>
<build>
<pluginManagement>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import org.springframework.integration.handler.advice.HandleMessageAdvice;
import org.springframework.integration.store.MessageGroupStore;
import org.springframework.integration.support.locks.LockRegistry;
import org.springframework.integration.support.management.AbstractMessageHandlerMetrics;
import org.springframework.messaging.MessageChannel;
import org.springframework.messaging.MessageHandler;
import org.springframework.scheduling.TaskScheduler;
Expand All @@ -49,12 +48,6 @@ public class MessageConnectorAggregatorFactoryBean extends AbstractSimpleMessage

private String outputChannelName;

private AbstractMessageHandlerMetrics metrics;

private Boolean statsEnabled;

private Boolean countsEnabled;

private LockRegistry lockRegistry;

private MessageGroupStore messageStore;
Expand All @@ -80,32 +73,30 @@ public class MessageConnectorAggregatorFactoryBean extends AbstractSimpleMessage
private Boolean expireGroupsUponTimeout;

private Boolean completeGroupsWhenEmpty;

private Boolean popSequence;

private Boolean releaseLockBeforeSend;

public MessageConnectorAggregatorFactoryBean() {
super();

// defaults
this.popSequence(false)
.completeGroupsWhenEmpty(true)
.expireGroupsUponCompletion(true)
.sendPartialResultOnExpiry(true)
.statsEnabled(true)
.countsEnabled(true);
.sendPartialResultOnExpiry(true);
}

public MessageConnectorAggregatorFactoryBean processorBean(MessageGroupProcessor processorBean) {
this.processorBean = processorBean;

return this;
}

public MessageConnectorAggregatorFactoryBean expireGroupsUponCompletion(Boolean expireGroupsUponCompletion) {
this.expireGroupsUponCompletion = expireGroupsUponCompletion;

return this;
}

Expand All @@ -127,24 +118,6 @@ public MessageConnectorAggregatorFactoryBean outputChannel(MessageChannel output
return this;
}

public MessageConnectorAggregatorFactoryBean metrics(AbstractMessageHandlerMetrics metrics) {
this.metrics = metrics;

return this;
}

public MessageConnectorAggregatorFactoryBean statsEnabled(Boolean statsEnabled) {
this.statsEnabled = statsEnabled;

return this;
}

public MessageConnectorAggregatorFactoryBean countsEnabled(Boolean countsEnabled) {
this.countsEnabled = countsEnabled;

return this;
}

public MessageConnectorAggregatorFactoryBean lockRegistry(LockRegistry lockRegistry) {
this.lockRegistry = lockRegistry;

Expand Down Expand Up @@ -195,7 +168,7 @@ public MessageConnectorAggregatorFactoryBean discardChannel(MessageChannel disca

public MessageConnectorAggregatorFactoryBean discardChannelName(String discardChannelName) {
this.discardChannelName = discardChannelName;

return this;
}

Expand Down Expand Up @@ -234,19 +207,19 @@ public MessageConnectorAggregatorFactoryBean completeGroupsWhenEmpty(Boolean com

return this;
}

public MessageConnectorAggregatorFactoryBean beanFactory(BeanFactory beanFactory) {
this.setBeanFactory(beanFactory);

return this;
}

public MessageConnectorAggregatorFactoryBean adviceChain(List<? extends HandleMessageAdvice> adviceChain) {
this.setAdviceChain(Arrays.asList(adviceChain.toArray(new HandleMessageAdvice[] {})));

return this;
}

@Override
protected MessageConnectorAggregator createHandler() {
MessageConnectorAggregator aggregator = new MessageConnectorAggregator(this.processorBean);
Expand All @@ -263,18 +236,6 @@ protected MessageConnectorAggregator createHandler() {
aggregator.setOutputChannelName(this.outputChannelName);
}

if (this.metrics != null) {
aggregator.configureMetrics(this.metrics);
}

if (this.statsEnabled != null) {
aggregator.setStatsEnabled(this.statsEnabled);
}

if (this.countsEnabled != null) {
aggregator.setCountsEnabled(this.countsEnabled);
}

if (this.lockRegistry != null) {
aggregator.setLockRegistry(this.lockRegistry);
}
Expand Down Expand Up @@ -326,7 +287,7 @@ protected MessageConnectorAggregator createHandler() {
if (this.completeGroupsWhenEmpty != null) {
aggregator.setCompleteGroupsWhenEmpty(this.completeGroupsWhenEmpty);
}

if (this.popSequence != null) {
aggregator.setPopSequence(this.popSequence);
}
Expand Down
4 changes: 2 additions & 2 deletions activiti-cloud-messages-service/starters/hazelcast/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
</parent>
<artifactId>activiti-cloud-starter-messages-hazelcast</artifactId>
<properties>
<spring-integration-hazelcast.version>2.0.0.RELEASE</spring-integration-hazelcast.version>
<hazelcast.version>3.12.4</hazelcast.version>
<spring-integration-hazelcast.version>3.0.0</spring-integration-hazelcast.version>
<hazelcast.version>4.0.3</hazelcast.version>
</properties>
<dependencyManagement>
<dependencies>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
<artifactId>activiti-cloud-services-modeling-rest</artifactId>
<name>Activiti Cloud Services :: Modeling REST</name>
<dependencies>
<dependency>
<groupId>org.activiti.cloud</groupId>
<artifactId>activiti-cloud-service-common-config</artifactId>
</dependency>
<dependency>
<groupId>org.activiti.cloud</groupId>
<artifactId>activiti-cloud-services-modeling-core</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
<artifactId>activiti-cloud-starter-modeling</artifactId>
<name>Activiti Cloud Starter :: Modeling</name>
<dependencies>
<dependency>
<groupId>org.activiti.cloud</groupId>
<artifactId>activiti-cloud-service-common-config</artifactId>
</dependency>
<dependency>
<groupId>org.activiti.cloud</groupId>
<artifactId>activiti-cloud-services-modeling-api</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion activiti-cloud-modeling-service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<module>activiti-cloud-acceptance-tests-modeling</module>
</modules>
<properties>
<activiti.version>7.1.279</activiti.version>
<activiti.version>0.0.1-PR-3505-6694-SNAPSHOT</activiti.version>
<everit-json-schema.version>1.12.1</everit-json-schema.version>
<commons-collections4.version>4.4</commons-collections4.version>
</properties>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,9 @@
<artifactId>spring-boot-configuration-processor</artifactId>
<optional>true</optional>
</dependency>
<dependency>
<groupId>io.projectreactor.addons</groupId>
<artifactId>reactor-extra</artifactId>
</dependency>
</dependencies>
</project>
Loading